Summary: | t/db_dependent/www/search_utf8.t hangs if error is returned | ||
---|---|---|---|
Product: | Koha | Reporter: | Tomás Cohen Arazi (tcohen) <tomascohen> |
Component: | Test Suite | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Galen Charlton <gmcharlt> |
Severity: | normal | ||
Priority: | P5 - low | CC: | brendan, f.demians, jonathan.druart, julian.maurice, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
Bug 14158: www search tests - Cleanup at the end
Bug 14158: www search tests - Cleanup at the end |
Description
Tomás Cohen Arazi (tcohen)
2015-05-06 15:03:37 UTC
There should be (at least) a reasonable timeout. Created attachment 49676 [details] [review] Bug 14158: www search tests - Cleanup at the end When something wrong happen, the parent process is waiting for the children to finish, but they have been zombified and the test hangs. To fix that, we should ensure that the cleanup is correctly done and that the processes are correctly killed. Test plan: export KOHA_USER=koha export KOHA_PASS=koha export KOHA_INTRANET_URL=http://do_not_exist_but_its_expected export KOHA_OPAC_URL=http://another_url prove t/db_dependent/www/search_utf8.t Without this patch, the tests will hang With the patch applied, they won't! Created attachment 49684 [details] [review] Bug 14158: www search tests - Cleanup at the end When something wrong happen, the parent process is waiting for the children to finish, but they have been zombified and the test hangs. To fix that, we should ensure that the cleanup is correctly done and that the processes are correctly killed. Test plan: export KOHA_USER=koha export KOHA_PASS=koha export KOHA_INTRANET_URL=http://do_not_exist_but_its_expected export KOHA_OPAC_URL=http://another_url prove t/db_dependent/www/search_utf8.t Without this patch, the tests will hang With the patch applied, they won't! Signed-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar> QAing as it is a trivial test fix no one has cared about yet :-D Pushed to Master - Should be in the May 2016 release. Thanks! Patch pushed to 3.22.x, will be in 3.22.6 Pushed to 3.20.x, will be in 3.20.11. |