Summary: | MARC21 773 -- Display when ind1 = 0 or blank | ||
---|---|---|---|
Product: | Koha | Reporter: | Winona Salesky <wsalesky> |
Component: | Templates | Assignee: | Winona Salesky <wsalesky> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | indradg, kyle, m.de.rooy, nicole, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 14181 : MARC21 773 -- Display when ind1 = 0 or blank
Bug 14181 : MARC21 773 -- Display when ind1 = 0 or blank [PASSED QA] Bug 14181 : MARC21 773 -- Display when ind1 = 0 or blank |
Description
Winona Salesky
2015-05-11 14:29:06 UTC
Created attachment 39050 [details] [review] Bug 14181 : MARC21 773 -- Display when ind1 = 0 or blank Display 773 in opac and staff details when ind1 !=1 Test Plan: 1) Apply this patch 2) Ensure you are using the default XSLT setting for the staff and opac search results and record details 3) Find or create a record with MARC tags 773 with ind1 set to 0 or blanks 4) Check display 6) Repeat steps 3 and 4 for the staff interface (In reply to Winona Salesky from comment #0) > Currently 773 is set to display if ind1=0 and is suppressed if ind1 = ''. > Patch will change code to display if ind1 != 1. So it will catch both > scenarios. Apologies in advance for my ignorance. but isn't the point of leaving ind1 as other than 1, is to suppress the display of the note? Created attachment 39054 [details] [review] Bug 14181 : MARC21 773 -- Display when ind1 = 0 or blank Display 773 in opac and staff details when ind1 !=1 Test plan ========= 1/ Add a new record which uses the 773 field to an instance running master code. (the selected MARC framework should have the 773's relevant sub-fields enabled and visible on staff client, opac and the editor). 2/ Set ind1 as '0' (zero). The note should be displayed both on OPAC as well as the staff client. 3/ Reset ind1 with a non-zero value or leave it blank. The display note should no longer be visible from either client or opac. 4/ Apply the patch. 5/ Repeat step #1 and #2. The note is displayed on staff and opac. 6/ Repeat step #3. The display note should be visible on both staff and opac. 7/ run koha-qa.pl -c 1 -v 2 Note : For #1 above, the following LoC record was used: http://www.loc.gov/marc/bibliographic/examples.html#monographic The patch applied cleanly and performed as expected. The koha-qa.pl gave OK as results. Signed-off-by: Indranil Das Gupta <indradg@gmail.com> I believe that coding ind1=0 is to suppress the display, 1 to display, and blank is just a default value. According to my understanding of the LOC rules indicate the element should be displayed as the default, or unless expressly coded as 0. Any other catalogers want to chime in? Thanks! -Winona (In reply to Indranil Das Gupta from comment #2) > (In reply to Winona Salesky from comment #0) > > Currently 773 is set to display if ind1=0 and is suppressed if ind1 = ''. > > Patch will change code to display if ind1 != 1. So it will catch both > > scenarios. > > Apologies in advance for my ignorance. but isn't the point of leaving ind1 > as other than 1, is to suppress the display of the note? (In reply to Winona Salesky from comment #4) > I believe that coding ind1=0 is to suppress the display, 1 to display, and > blank is just a default value. According to my understanding of the LOC > rules indicate the element should be displayed as the default, or unless > expressly coded as 0. I discussed this with Galen Charlton, after I asked the question here. He agrees with the idea of you patch and said that should be default behavior if not set to 0. Great! Thanks, -Winona (In reply to Indranil Das Gupta from comment #5) > (In reply to Winona Salesky from comment #4) > > I believe that coding ind1=0 is to suppress the display, 1 to display, and > > blank is just a default value. According to my understanding of the LOC > > rules indicate the element should be displayed as the default, or unless > > expressly coded as 0. > > I discussed this with Galen Charlton, after I asked the question here. He > agrees with the idea of you patch and said that should be default behavior > if not set to 0. Created attachment 40937 [details] [review] [PASSED QA] Bug 14181 : MARC21 773 -- Display when ind1 = 0 or blank Display 773 in opac and staff details when ind1 !=1 Test plan ========= 1/ Add a new record which uses the 773 field to an instance running master code. (the selected MARC framework should have the 773's relevant sub-fields enabled and visible on staff client, opac and the editor). 2/ Set ind1 as '0' (zero). The note should be displayed both on OPAC as well as the staff client. 3/ Reset ind1 with a non-zero value or leave it blank. The display note should no longer be visible from either client or opac. 4/ Apply the patch. 5/ Repeat step #1 and #2. The note is displayed on staff and opac. 6/ Repeat step #3. The display note should be visible on both staff and opac. 7/ run koha-qa.pl -c 1 -v 2 Note : For #1 above, the following LoC record was used: http://www.loc.gov/marc/bibliographic/examples.html#monographic The patch applied cleanly and performed as expected. The koha-qa.pl gave OK as results. Signed-off-by: Indranil Das Gupta <indradg@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Patch pushed to master. Thanks Winona! Great! Thanks. -Winona (In reply to Tomás Cohen Arazi from comment #8) > Patch pushed to master. > > Thanks Winona! |