Summary: | branchtransfers GetAllTransfers and GetAllPendingTransfers functions to ease testing. | ||
---|---|---|---|
Product: | Koha | Reporter: | Olli-Antti Kivilahti <olli-antti.kivilahti> |
Component: | Circulation | Assignee: | Olli-Antti Kivilahti <olli-antti.kivilahti> |
Status: | CLOSED WONTFIX | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | gmcharlt, josef.moravec, katrin.fischer, kyle.m.hall, veron |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14187 | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Bug Depends on: | |||
Bug Blocks: | 9525 | ||
Attachments: |
Bug 14188 - branchtransfers GetAllTransfers and GetAllPendingTransfers functions to ease testing.
Bug 14188 - branchtransfers GetAllTransfers and GetAllPendingTransfers functions to ease testing. |
Description
Olli-Antti Kivilahti
2015-05-12 08:43:08 UTC
Created attachment 39061 [details] [review] Bug 14188 - branchtransfers GetAllTransfers and GetAllPendingTransfers functions to ease testing. Because there is no nice way of getting all branchtransfers and putting SQL into tests is VERY VERY BAD, introducing these branchtransfer API calls to conveniently get all transfers data nicely. Unit tests included. TEST PLAN: Run t/db_dependent/Circulation_transfers.t Created attachment 40076 [details] [review] Bug 14188 - branchtransfers GetAllTransfers and GetAllPendingTransfers functions to ease testing. Because there is no nice way of getting all branchtransfers and putting SQL into tests is VERY VERY BAD, introducing these branchtransfer API calls to conveniently get all transfers data nicely. Unit tests included. TEST PLAN: Run t/db_dependent/Circulation_transfers.t Wanted to test, but does not apply: Applying: Bug 14188 - branchtransfers GetAllTransfers and GetAllPendingTransfers functions to ease testing. fatal: sha1 information is lacking or useless (C4/Circulation.pm). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 14188 - branchtransfers GetAllTransfers and GetAllPendingTransfers functions to ease testing. Koha::Item::Transfers->search should be enough I think... Agreeing with Joseph - just changing status as BLOCKED usually indicates we are waiting for something higher up in the dependency tree. |