|
Description
Jonathan Druart
2015-05-13 15:57:09 UTC
Created attachment 39146 [details] [review] Bug 14197: Remove the warning on destroying TestBuilder objects This module will be called by db_dependent tests, which already create a transaction. TestBuilder creates a new one (which is certainly useless) and the rollback does not do anything. To see the warning see patches on bug 14045. Created attachment 40859 [details] [review] Bug 14197: TestBuilder - Remove the error on starting the transaction DBD::mysql::db begin_work failed: Already in a transaction at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1560. DBIx::Class::Storage::DBI::txn_rollback(): Storage transaction_depth 0 does not match false AutoCommit of DBI::db=HASH(0xa429648), attempting ROLLBACK anyway at t/lib/TestBuilder.pm line 363 (In reply to Jonathan Druart from comment #1) > To see the warning see patches on bug 14045. And the errors with the patch on bug 14494. Created attachment 42055 [details] [review] Used to test the change Jonathan: I cannot reproduce with the simple third patch. What should I change there to see behavior change with/without your patches? Oops, I lost some changes in that test file. But what exactly should trigger the error on txn_begin or end in testbuilder? Created attachment 42056 [details] [review] Used to test the change This seems to work like it should not.. Only this question: Why does the test abort with the DESTROY and does it only warn when I undef $builder ? (In reply to Marcel de Rooy from comment #8) > Only this question: Why does the test abort with the DESTROY and does it > only warn when I undef $builder ? Because the second DESTROY crashes the test :) Created attachment 42057 [details] [review] Bug 14197: Remove the warning on destroying TestBuilder objects This module will be called by db_dependent tests, which already create a transaction. TestBuilder creates a new one (which is certainly useless) and the rollback does not do anything. To see the warning see patches on bug 14045. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 42058 [details] [review] Bug 14197: TestBuilder - Remove the error on starting the transaction DBD::mysql::db begin_work failed: Already in a transaction at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1560. DBIx::Class::Storage::DBI::txn_rollback(): Storage transaction_depth 0 does not match false AutoCommit of DBI::db=HASH(0xa429648), attempting ROLLBACK anyway at t/lib/TestBuilder.pm line 363 Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 42059 [details] [review] [DO_NOT_PUSH] Used to test the change with/without first two patches Can I get a test plan please? (In reply to Katrin Fischer from comment #13) > Can I get a test plan please? Katrin: Run the test from the third patch with and without the two patches. Compare the results. Created attachment 42545 [details] [review] [PASSED QA] Bug 14197: Remove the warning on destroying TestBuilder objects This module will be called by db_dependent tests, which already create a transaction. TestBuilder creates a new one (which is certainly useless) and the rollback does not do anything. To see the warning see patches on bug 14045. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 42546 [details] [review] [PASSED QA] Bug 14197: TestBuilder - Remove the error on starting the transaction DBD::mysql::db begin_work failed: Already in a transaction at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1560. DBIx::Class::Storage::DBI::txn_rollback(): Storage transaction_depth 0 does not match false AutoCommit of DBI::db=HASH(0xa429648), attempting ROLLBACK anyway at t/lib/TestBuilder.pm line 363 Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Patches pushed to master. Thanks Jonathan! |