Summary: | Add '(All libraries)' to notice deletion confirmation page | ||
---|---|---|---|
Product: | Koha | Reporter: | Indranil Das Gupta <indradg> |
Component: | Notices | Assignee: | Indranil Das Gupta <indradg> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 14240 - Add '(All libraries)' to notice deletion form
Bug 14240 - Add '(All libraries)' to notice deletion form [PASSED QA] Bug 14240 - Add '(All libraries)' to notice deletion form |
Description
Indranil Das Gupta
2015-05-21 01:46:37 UTC
Created attachment 39355 [details] [review] Bug 14240 - Add '(All libraries)' to notice deletion form Trivial patch that shows (All libraries) instead of an empty cell for notices that are applicable across all libraries. Test plan ========= 1/ Apply the patch 2/ Attempt to delete a notice that is defined for all libraries You should be able to see '(All libraries)' in the table cell instead of a blank cell Created attachment 39931 [details] [review] Bug 14240 - Add '(All libraries)' to notice deletion form Trivial patch that shows (All libraries) instead of an empty cell for notices that are applicable across all libraries. Test plan ========= 1) Log in to staff client 2) Tools->Notices & slips 3) Add a dummy notice for all libraries -- test code, test description, email - test subject, test content Click Submit 4) Click Delete -- note that the Library column value is blank. 5) Click the no option 6) Apply this patch 7) Click Delete -- note that the Library column value is (All Libraries). 8) run koha qa test tools. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Created attachment 39960 [details] [review] [PASSED QA] Bug 14240 - Add '(All libraries)' to notice deletion form Trivial patch that shows (All libraries) instead of an empty cell for notices that are applicable across all libraries. Test plan ========= 1) Log in to staff client 2) Tools->Notices & slips 3) Add a dummy notice for all libraries -- test code, test description, email - test subject, test content Click Submit 4) Click Delete -- note that the Library column value is blank. 5) Click the no option 6) Apply this patch 7) Click Delete -- note that the Library column value is (All Libraries). 8) run koha qa test tools. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Patch pushed to master. Thanks Indranil! |