Summary: | RIS in unimarc flavour is still deficient | ||
---|---|---|---|
Product: | Koha | Reporter: | jvr <jvr> |
Component: | OPAC | Assignee: | Bernardo Gonzalez Kriegel <bgkriegel> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | bgkriegel, jonathan.druart, liz, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: |
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14832 http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14971 |
||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Attachments: |
Detail report (3) is what you get and (4) is what it should be
Bug 14245: Problems with RIS export in unimarc Bug 14245: Problems with RIS export in unimarc Bug 14245: Problems with RIS export in unimarc Bug 14245: (QA followup) already global |
Description
jvr
2015-05-21 15:41:34 UTC
Created attachment 39366 [details] [review] Bug 14245: Problems with RIS export in unimarc Variable $itype is used an all C4/Ris.pm to switch between marc falvors, but is local and not passed along as argument. As a quick solution, is defined as global To test: 1) On UNIMARC setup, export a record as RIS, check that author (and other fields) are displayed incorrectly 2) Apply the patch 3) Export again, improved results 4) Run t/Ris.t There are other problems in this script, needs maintenance (e.g. no Modern::Perl friendly) Victor, any chance to get your signoff on this patch? I already tested it and it works OK! Created attachment 42572 [details] [review] Bug 14245: Problems with RIS export in unimarc Variable $itype is used an all C4/Ris.pm to switch between marc falvors, but is local and not passed along as argument. As a quick solution, is defined as global To test: 1) On UNIMARC setup, export a record as RIS, check that author (and other fields) are displayed incorrectly 2) Apply the patch 3) Export again, improved results 4) Run t/Ris.t There are other problems in this script, needs maintenance (e.g. no Modern::Perl friendly) Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 42586 [details] [review] Bug 14245: Problems with RIS export in unimarc Variable $itype is used an all C4/Ris.pm to switch between marc falvors, but is local and not passed along as argument. As a quick solution, is defined as global To test: 1) On UNIMARC setup, export a record as RIS, check that author (and other fields) are displayed incorrectly 2) Apply the patch 3) Export again, improved results 4) Run t/Ris.t There are other problems in this script, needs maintenance (e.g. no Modern::Perl friendly) Signed-off-by: Victor do Rosário <jvr@fct.unl.pt> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 42608 [details] [review] Bug 14245: (QA followup) already global The original patch correctly unmasks the global variable (by removing the 'my' on the marc2ris function, but wrongly introduces a new global variable. Signed-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar> Patch pushed to master. Thanks Bernardo! pushed to 3.18.x, will be in 3.18.11. Also looks like it was pushed to 3.20.x, and included in 3.20.04 |