Summary: | Improve discharge letter sample notice | ||
---|---|---|---|
Product: | Koha | Reporter: | Nicole C. Engard <nengard> |
Component: | Installation and upgrade (web-based installer) | Assignee: | Katrin Fischer <katrin.fischer> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | gmcharlt, indradg, jonathan.druart, katrin.fischer, kyle.m.hall, tomascohen |
Version: | master | ||
Hardware: | All | ||
OS: | All | ||
See Also: | http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14251 | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Attachments: |
letter image
Bug 14249: Improve sample discharge letter (en) [SIGNED-OFF] Bug 14249: Improve sample discharge letter (en) [PASSED QA] Bug 14249: Improve sample discharge letter (en) |
Description
Nicole C. Engard
2015-05-21 16:46:49 UTC
Created attachment 39364 [details]
letter image
Hi Nicole, I offer to write the patch, but can you write the text for me? Something like either of these: <heading>Discharge Confirmation</heading> <right>TODAYS DATE</right> BRANCH NAME certifies that the following borrower: FIRSTNAME SURNAME, Cardnumber: CARDNUMBER currently has no items checked out. Or <heading>Discharge Confirmation</heading> <right>TODAYS DATE</right> BRANCH NAME certifies that the following borrower: FIRSTNAME SURNAME, Cardnumber: CARDNUMBER has returned all items. Created attachment 39936 [details] [review] Bug 14249: Improve sample discharge letter (en) Improves formatting and wording as suggested by Nicole on bug 14249. To test: - Activate UseDischarge - Request a discharge from a patron account in the OPAC - Confirm discharge from the start page of the staff interface - Download PDF from the patron account in the OPAC - Verify the displayed text is formatted and reads correctly 06/06/2015 15:18 Discharge confirmation Midway certifies that the following borrower: Firstname surname (cardnumber: 1) has returned all items. Hi Nicole, could you check the attached changes are ok? Once the English text is ok, I will write a patch for the translated installers as well. I didn't manage to change the text alignment with embedded CSS - not sure how this can be done. Created attachment 40327 [details] [review] [SIGNED-OFF] Bug 14249: Improve sample discharge letter (en) Improves formatting and wording as suggested by Nicole on bug 14249. To test: - Activate UseDischarge - Request a discharge from a patron account in the OPAC - Confirm discharge from the start page of the staff interface - Download PDF from the patron account in the OPAC - Verify the displayed text is formatted and reads correctly 06/06/2015 15:18 Discharge confirmation Midway certifies that the following borrower: Firstname surname (cardnumber: 1) has returned all items. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Messages is Ok, no errors I think you cant modify message using embeded CSS, html -> pdf procedure ignores CSS. Created attachment 40407 [details] [review] [PASSED QA] Bug 14249: Improve sample discharge letter (en) Improves formatting and wording as suggested by Nicole on bug 14249. To test: - Activate UseDischarge - Request a discharge from a patron account in the OPAC - Confirm discharge from the start page of the staff interface - Download PDF from the patron account in the OPAC - Verify the displayed text is formatted and reads correctly 06/06/2015 15:18 Discharge confirmation Midway certifies that the following borrower: Firstname surname (cardnumber: 1) has returned all items. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Messages is Ok, no errors I think you cant modify message using embeded CSS, html -> pdf procedure ignores CSS. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Patch pushed to master. Thanks Katrin! |