Bug 14253

Summary: Can't scroll though patron notify list on new order
Product: Koha Reporter: Nicole C. Engard <nengard>
Component: AcquisitionsAssignee: Katrin Fischer <katrin.fischer>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: aleisha, chris, katrin.fischer, mirko, tomascohen
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: can't scroll
Bug 14253: Acq - notify borrowers popup needs to allow scrolling
Bug 14253: Acq - notify borrowers popup needs to allow scrolling
Bug 14253: Acq - notify borrowers popup needs to allow scrolling
Bug 14253: (follow-up) Same fix for the basket page

Description Nicole C. Engard 2015-05-21 18:35:22 UTC
Created attachment 39370 [details]
can't scroll

When trying to add patrons to notify of new acq you can't scroll using the scroll button on the mouse or the scroll bar - which doesn't exist.
Comment 1 Katrin Fischer 2015-06-09 01:16:33 UTC Comment hidden (obsolete)
Comment 2 Aleisha Amohia 2015-06-10 04:09:06 UTC
Patch applied cleanly and I still see no scrollbars, so will set to Failed QA.
Comment 3 Katrin Fischer 2015-06-10 07:32:42 UTC
Hi Aleisha, did you make sure that you closed the popup window before testing with the patch? That's what happened to me at first. Which browser?
Comment 4 Mirko Tietgen 2015-06-11 18:03:29 UTC Comment hidden (obsolete)
Comment 5 Jonathan Druart 2015-06-16 15:40:21 UTC
Created attachment 40187 [details] [review]
Bug 14253: Acq - notify borrowers popup needs to allow scrolling

The 'notify on receiving' patron search on the new order form
in acquisitions didn't allow you to scroll, so there was no
way to select users from the bottom of a longer result list.

To test:
- Create a new order in acquisitions
- On the order form, use the 'Add user' button to open
  the popup
- Perform a patron research with a lot of results
- Verify that with the patch you can scroll, but
  that you couldn't without it

Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>
without patch: no scroll bar in Firefox 38
with patch: scrolling works fine

Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org>
Comment 6 Jonathan Druart 2015-06-16 15:40:29 UTC
Created attachment 40188 [details] [review]
Bug 14253: (follow-up) Same fix for the basket page

Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org>
Comment 7 Tomás Cohen Arazi 2015-06-22 20:09:52 UTC
Patch pushed to master.

Thanks Katrina!
Comment 8 Chris Cormack 2015-07-10 01:59:42 UTC
Pushed to 3.20.x will be in 3.20.2