Summary: | Can't scroll though patron notify list on new order | ||
---|---|---|---|
Product: | Koha | Reporter: | Nicole C. Engard <nengard> |
Component: | Acquisitions | Assignee: | Katrin Fischer <katrin.fischer> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | aleisha, chris, katrin.fischer, mirko, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Attachments: |
can't scroll
Bug 14253: Acq - notify borrowers popup needs to allow scrolling Bug 14253: Acq - notify borrowers popup needs to allow scrolling Bug 14253: Acq - notify borrowers popup needs to allow scrolling Bug 14253: (follow-up) Same fix for the basket page |
Created attachment 40007 [details] [review] Bug 14253: Acq - notify borrowers popup needs to allow scrolling The 'notify on receiving' patron search on the new order form in acquisitions didn't allow you to scroll, so there was no way to select users from the bottom of a longer result list. To test: - Create a new order in acquisitions - On the order form, use the 'Add user' button to open the popup - Perform a patron research with a lot of results - Verify that with the patch you can scroll, but that you couldn't without it Patch applied cleanly and I still see no scrollbars, so will set to Failed QA. Hi Aleisha, did you make sure that you closed the popup window before testing with the patch? That's what happened to me at first. Which browser? Created attachment 40096 [details] [review] Bug 14253: Acq - notify borrowers popup needs to allow scrolling The 'notify on receiving' patron search on the new order form in acquisitions didn't allow you to scroll, so there was no way to select users from the bottom of a longer result list. To test: - Create a new order in acquisitions - On the order form, use the 'Add user' button to open the popup - Perform a patron research with a lot of results - Verify that with the patch you can scroll, but that you couldn't without it Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> without patch: no scroll bar in Firefox 38 with patch: scrolling works fine Created attachment 40187 [details] [review] Bug 14253: Acq - notify borrowers popup needs to allow scrolling The 'notify on receiving' patron search on the new order form in acquisitions didn't allow you to scroll, so there was no way to select users from the bottom of a longer result list. To test: - Create a new order in acquisitions - On the order form, use the 'Add user' button to open the popup - Perform a patron research with a lot of results - Verify that with the patch you can scroll, but that you couldn't without it Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> without patch: no scroll bar in Firefox 38 with patch: scrolling works fine Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org> Created attachment 40188 [details] [review] Bug 14253: (follow-up) Same fix for the basket page Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org> Patch pushed to master. Thanks Katrina! Pushed to 3.20.x will be in 3.20.2 |
Created attachment 39370 [details] can't scroll When trying to add patrons to notify of new acq you can't scroll using the scroll button on the mouse or the scroll bar - which doesn't exist.