Bug 14269

Summary:	OPAC: Small template improvements to full serial history page
Product:	Koha	Reporter:	Katrin Fischer <katrin.fischer>
Component:	OPAC	Assignee:	Katrin Fischer <katrin.fischer>
Status:	CLOSED FIXED	QA Contact:	Testopia <testopia>
Severity:	minor
Priority:	P5 - low	CC:	chris, tomascohen, veron
Version:	Main
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	Small patch
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:
Circulation function:
Attachments:	Bug 14269: OPAC: Some template improvements for the full serial history page [Signed-off] Bug 14269: OPAC: Some template improvements for the full serial history page Bug 14269: OPAC: Some template improvements for the full serial history page

Description Katrin Fischer 2015-05-25 10:12:31 UTC

3 small issues on the full serial history page in OPAC:

- Punctuation is not quite right, filters are labelled:
  Library :
  Subscription :
- (All) in the filter pull downs is not translatable
- Table and filters use branchcode instead of branchname

Comment 1 Katrin Fischer 2015-05-25 10:19:59 UTC Comment hidden (obsolete)

Created attachment 39480 [details] [review]
Bug 14269: OPAC: Some template improvements for the full serial history page

- Fix filter labels:
  Library : -> Library:
  Subscription : -> Subscription:
- Make '(All)' entry in filter pull downs translatable
- Show branch name instead of branchcode in table and filter

To test:
- Verify changes as described above
- Verify filters still work as expected

Comment 2 Marc Véron 2015-05-29 15:01:19 UTC Comment hidden (obsolete)

Created attachment 39690 [details] [review]
[Signed-off] Bug 14269: OPAC: Some template improvements for the full serial history page

- Fix filter labels:
  Library : -> Library:
  Subscription : -> Subscription:
- Make '(All)' entry in filter pull downs translatable
- Show branch name instead of branchcode in table and filter

To test:
- Verify changes as described above
- Verify filters still work as expected

Followed test plan. Works as expected.
Signed-off-by: Marc Véron <veron@veron.ch>

Comment 3 Jonathan Druart 2015-06-04 11:04:05 UTC

Created attachment 39846 [details] [review]
Bug 14269: OPAC: Some template improvements for the full serial history page

- Fix filter labels:
  Library : -> Library:
  Subscription : -> Subscription:
- Make '(All)' entry in filter pull downs translatable
- Show branch name instead of branchcode in table and filter

To test:
- Verify changes as described above
- Verify filters still work as expected

Followed test plan. Works as expected.
Signed-off-by: Marc Véron <veron@veron.ch>

Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org>

Comment 4 Tomás Cohen Arazi (tcohen) 2015-06-04 14:15:57 UTC

Patch pushed to master.

Thanks Katrina!

Comment 5 Chris Cormack 2015-06-07 08:13:21 UTC

Pushed to 3.20.x will be in 3.20.1