Bug 14280

Summary: Add branches fields to discharges letters
Product: Koha Reporter: Matthias Meusburger <matthias.meusburger>
Component: NoticesAssignee: Bugs List <koha-bugs>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: gmcharlt, katrin.fischer, kyle.m.hall, tomascohen, veron
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Bug 14280: Add branches fields to discharges letters
[Signed-off] Bug 14280: Add branches fields to discharges letters
[PASSED QA] Bug 14280: Add branches fields to discharges letters

Description Matthias Meusburger 2015-05-27 09:51:56 UTC
Currently, when generating a discharge letter, branches fields are not translated in the letter (<<branches.branchname>>, <<branches.branchaddress1>>, etc.)

This patch fixes that.
Comment 1 Matthias Meusburger 2015-05-27 09:54:00 UTC Comment hidden (obsolete)
Comment 2 Marc Véron 2015-06-05 08:59:58 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2015-06-06 12:47:14 UTC
Created attachment 39935 [details] [review]
[PASSED QA] Bug 14280: Add branches fields to discharges letters

Currently, when generating a discharge letter, branches fields are not translated in the letter (<<branches.branchname>>, <<branches.branchaddress1>>, etc.)
This patch fixes that.

How I tested:
- Set syspref 'useDischarge' to 'allow'
- Go to Home > Tools > Notices & Slips
- Edit DISCHARGE, add to 'Email message':
<p><<branches.branchname>><br />
<<branches.branchaddress1>><br />
<<branches.branchaddress2>><br />
<<branches.branchaddress3>><br />
<<branches.zip>> <<branches.city>><br />
</p>
- Go to detail page of a patron > discharge
- Click 'Generate discharge'
- Verify that the PDF contains the information above.

Signed-off-by: Marc Véron <veron@veron.ch>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Tomás Cohen Arazi 2015-06-11 17:40:07 UTC
Enhancement pushed to master.

Thanks Matthias!