Summary: | Typo in Languages.pm | ||
---|---|---|---|
Product: | Koha | Reporter: | Indranil Das Gupta <indradg> |
Component: | Architecture, internals, and plumbing | Assignee: | Indranil Das Gupta <indradg> |
Status: | RESOLVED DUPLICATE | QA Contact: | Testopia <testopia> |
Severity: | trivial | ||
Priority: | P3 | CC: | bgkriegel, mtompset |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: | Bug 14284 - Fixes typo 'native_descrition' |
Description
Indranil Das Gupta
2015-05-28 00:24:24 UTC
Created attachment 39624 [details] [review] Bug 14284 - Fixes typo 'native_descrition' Fixes the following typo (originally line 102 in C4/Languages.pm): 'native_descrition'=>$language_set->{language_native_description} } to read: 'native_description'=>$language_set->{language_native_description} } Test plan ========= 1/ in your git installdir do a `grep -R native native_descrition`. it should return only one single reference to this line in C4/Languages.pm 2/ open the file C4/Languages.pm, go to line #102 to confirm it. close the file 3/ apply patch 4/ re-run `grep -R native native_descrition`, this time nothing should be returned. Someone missed that?! Write some tests, so I can sign this sucker off! Bug 12017 has a patch piece that removes this function completely. I'm sure the correct course of action will be taken with respect to this function (getFrameworkLanguages) there. *** This bug has been marked as a duplicate of bug 12017 *** (In reply to M. Tompsett from comment #3) > Bug 12017 has a patch piece that removes this function completely. I'm sure > the correct course of action will be taken with respect to this function > (getFrameworkLanguages) there. > Was about to said that, it's dead code (In reply to Bernardo Gonzalez Kriegel from comment #4) > (In reply to M. Tompsett from comment #3) > > Bug 12017 has a patch piece that removes this function completely. I'm sure > > the correct course of action will be taken with respect to this function > > (getFrameworkLanguages) there. > > > > Was about to said that, it's dead code bgkriegel++ for 12017! :) |