Summary: | Add a table foot to circulation matrix | ||
---|---|---|---|
Product: | Koha | Reporter: | Nicolas Legrand <nicolas.legrand> |
Component: | System Administration | Assignee: | Bugs List <koha-bugs> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | chris, gmcharlt, indradg, jonathan.druart, liz, mtj, tomascohen, veron |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 14290: Add a table foot to circulation matrix
[Signed-off] Bug 14290: Add a table foot to circulation matrix [PASSED QA] Bug 14290: Add a table foot to circulation matrix Bug 14290 - fix number of columns in footer for 3.18 Bug 14290 - fix number of columns in footer for 3.18 |
Description
Nicolas Legrand
2015-05-28 14:32:17 UTC
Created attachment 39639 [details] [review] Bug 14290: Add a table foot to circulation matrix Reprint circulation matrix header in a footer helps editing entries in big matrix. Otherwise, the header disapears and it's hard to tell which columns we're editing. Test plan : try do add, modify or delete some entries in the circulation matrix, everything should work as expected. Hi Nicolas, What do you think about having the column headers as 'title' attribute in the td tags? We would then have nice tooltips related to each entry. Marc Hey Marc, (In reply to Marc Véron from comment #2) > Hi Nicolas, > > What do you think about having the column headers as 'title' attribute in > the td tags? We would then have nice tooltips related to each entry. Thank you for your suggestion. I'm not sure about it for editing. If I want edit just an entry, the full footer permits me to find that entry in a trice. Having to over every field seems longer to me. I think the footer is better for editing. However, the tooltip might be an excellent idea for an other purpose : know what value a value is about when lost in a big circulation matrix. That was maybe what you were thinking about? My idea was to have the tooltip as an addition, not as an alternative to the table footer. Created attachment 39667 [details] [review] [Signed-off] Bug 14290: Add a table foot to circulation matrix Reprint circulation matrix header in a footer helps editing entries in big matrix. Otherwise, the header disapears and it's hard to tell which columns we're editing. Test plan : try do add, modify or delete some entries in the circulation matrix, everything should work as expected. Patch works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Created attachment 39716 [details] [review] [PASSED QA] Bug 14290: Add a table foot to circulation matrix Reprint circulation matrix header in a footer helps editing entries in big matrix. Otherwise, the header disapears and it's hard to tell which columns we're editing. Test plan : try do add, modify or delete some entries in the circulation matrix, everything should work as expected. Patch works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Nice little patch and an improvement until we can come up with something better to make the big table easier to handle. I dream of an editable table, where the header always stays visible on top... with sorting and filtering options *sigh* ;) Patch pushed to master. Nice improvement, Nicolas! Pushed to 3.20.x will be in 3.20.2 Created attachment 41019 [details] [review] Bug 14290 - fix number of columns in footer for 3.18 Jonathan pointed out that the smart rules table is slightly different in 3.20, this commit cleans it up for 3.18. Comment on attachment 41019 [details] [review] Bug 14290 - fix number of columns in footer for 3.18 actually, i have something extra in here. one moment. Created attachment 41020 [details] [review] Bug 14290 - fix number of columns in footer for 3.18 Jonathan pointed out that the smart rules table is slightly different in 3.20, this commit cleans it up for 3.18. Pushed to 3.18.x will be in 3.18.09 Possible selection for 3.16.x?... needs testing Mason - the 3.18 version may be closer to what you need :) The table footer should not be contained in the table body. A correct table structure is: table -tbody -tfoot not table -tbody -tfoot |