Bug 14300

Summary:	siplogs do not record process IDs
Product:	Koha	Reporter:	Barton Chittenden <barton>
Component:	SIP2	Assignee:	Martin Renvoize (ashimema) <martin.renvoize>
Status:	CLOSED FIXED	QA Contact:	Kyle M Hall (khall) <kyle>
Severity:	enhancement
Priority:	P5 - low	CC:	andrew, colin.campbell, fridolin.somers, jonathan.druart, kyle, martin.renvoize, nick, tomascohen
Version:	unspecified
Hardware:	All
OS:	All
See Also:	http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14167 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25464
Change sponsored?:	---	Patch complexity:	---
Documentation contact:		Documentation submission:
Text to go in the release notes:	This addition to the default configuration for the SIP section of the Log4Perl configuration will add the process ID to the log lines for SIP logs. This allows for tracing a transaction from start to finish when using forked SIP services.	Version(s) released in:	21.05.00,20.11.06
Circulation function:
Attachments:	Bug 14300: Add %P to SIP LogPattern Bug 14300: Add %P to SIP LogPattern

Description Barton Chittenden 2015-05-29 19:24:56 UTC

This makes correlating events in sip-output.log and syslog impossible.

Comment 1 Barton Chittenden 2016-01-21 20:36:03 UTC

This is addressed by Bug 15253 -- possible duplicate?

Comment 2 Martin Renvoize (ashimema) 2021-04-16 09:58:21 UTC

We add timestamps by default, but we're still not recording PID.. we should add the `%P` required to log PID to the default log4perl configs.

Comment 3 Martin Renvoize (ashimema) 2021-04-16 10:04:56 UTC

Created attachment 119701 [details] [review]
Bug 14300: Add %P to SIP LogPattern

This patch adds `%P` to the SIP log4perl configuration so that PID is
recorded against log lines.

This allows transactions to be more easily tied together under one
SIPServer, thus making it easier to pick out a whole transaction from
start to finish.

Comment 4 Kyle M Hall (khall) 2021-04-16 12:21:35 UTC

Created attachment 119724 [details] [review]
Bug 14300: Add %P to SIP LogPattern

This patch adds `%P` to the SIP log4perl configuration so that PID is
recorded against log lines.

This allows transactions to be more easily tied together under one
SIPServer, thus making it easier to pick out a whole transaction from
start to finish.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Comment 5 Jonathan Druart 2021-04-21 13:29:21 UTC

Pushed to master for 21.05, thanks to everybody involved!

Comment 6 Fridolin Somers 2021-04-29 13:23:09 UTC

Small useful enhancement, I choose to backport.

Pushed to 20.11.x for 20.11.06

Comment 7 Fridolin Somers 2021-04-29 13:24:02 UTC

PS :
We should consider this also for Plack non ?
Since there are several workers.

Comment 8 Andrew Fuerste-Henry 2021-05-24 16:22:51 UTC

Enhancement, not backported to 20.05