Bug 14330

Summary: Remove unused email_sender from sendbasket/sendshelf
Product: Koha Reporter: Marcel de Rooy <m.de.rooy>
Component: TemplatesAssignee: Marcel de Rooy <m.de.rooy>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: trivial    
Priority: P5 - low CC: chris, mtj, tomascohen, veron, wizzyrea
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Bug 14330: Remove unused email_sender from sendbasket/sendshelf
[Signed-off] Bug 14330: Remove unused email_sender from sendbasket/sendshelf
[PASSED QA] Bug 14330: Remove unused email_sender from sendbasket/sendshelf

Description Marcel de Rooy 2015-06-04 10:47:01 UTC
The sendbasket/sendshelf scripts and templates do not use email_sender as a cgi parameter or as a template var. Probably a leftover from previous changes.
Let's make Koha cleaner :)
Comment 1 Marcel de Rooy 2015-06-04 10:50:03 UTC Comment hidden (obsolete)
Comment 2 Marc Véron 2015-06-04 14:29:23 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2015-06-06 16:46:07 UTC
Created attachment 39941 [details] [review]
[PASSED QA] Bug 14330: Remove unused email_sender from sendbasket/sendshelf

The sendbasket/sendshelf scripts and templates do not use email_sender
as a cgi parameter or as a template var. Probably a leftover from previous
changes.
Let's make Koha cleaner :)

Test plan:
[1] Send your cart from opac or staff.
[2] Send a shelf from opac or staff.
[3] Git grep email_sender. No results.

Followed test plan. Works as expected.
Signed-off-by: Marc Véron <veron@veron.ch>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Tomás Cohen Arazi 2015-06-08 14:09:54 UTC
Patch pushed to master.

Thanks Marcel!
Comment 5 Chris Cormack 2015-06-08 20:38:55 UTC
Pushed to 3.20.x will be in 3.20.1
Comment 6 Liz Rea 2015-06-22 22:44:07 UTC
Patch pushed to 3.18.x will be in 3.18.08
Comment 7 Mason James 2015-07-25 04:55:07 UTC
Skipping for 3.16.x series, due to patch conflicts