Bug 14347

Summary: Running overdue_notices.pl with --html flag set does not create well structured html
Product: Koha Reporter: Barton Chittenden <barton>
Component: NoticesAssignee: Bugs List <koha-bugs>
Status: RESOLVED DUPLICATE QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: magnus, michaela.sieber, nengard, somesecretemail
Version: unspecified   
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29354
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:

Description Barton Chittenden 2015-06-05 18:38:53 UTC
When overdue_notices.pl creates the email containing un-emailed notices, and the --html flag is set, the resulting file is not a well structured HTML file:

* It contains no DTD
* There are no <html> tags
* It has no header
  * The file pointed to by the NoticesCSS syspref *should* be included, but is not
* It has no body
* The body of the individual messages is wrapped in <pre> tags, which is unnecessary, ugly, and precludes the use of styling of the notices (If you want unstyled notices, why not use text?)
* The file is always named 'attachment.txt' regardless of whether the script is called using the "--html" or "--text" flags.
Comment 1 Katrin Fischer 2020-01-07 22:05:57 UTC
*** Bug 14281 has been marked as a duplicate of this bug. ***
Comment 2 Katrin Fischer 2020-04-05 12:25:50 UTC
*** Bug 24505 has been marked as a duplicate of this bug. ***
Comment 3 Magnus Enger 2022-12-12 13:11:32 UTC
> * The file is always named 'attachment.txt' regardless of whether the script is called using the "--html" or "--text" flags.

This is adressed in Bug 29354.
Comment 4 Michaela Sieber 2023-06-16 20:11:38 UTC
(In reply to Magnus Enger from comment #3)
> > * The file is always named 'attachment.txt' regardless of whether the script is called using the "--html" or "--text" flags.
> 
> This is adressed in Bug 29354.


Perhaps this bug should be marked as RESOLVED DUPLICATE of bug 29354 ?
Comment 5 Katrin Fischer 2023-08-05 11:49:42 UTC

*** This bug has been marked as a duplicate of bug 29354 ***