Summary: | Remove given-when from opac-search.pl | ||
---|---|---|---|
Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
Component: | Architecture, internals, and plumbing | Assignee: | Katrin Fischer <katrin.fischer> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | chris, tomascohen, wizzyrea |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 13307 | ||
Bug Blocks: | |||
Attachments: |
Bug 14351: Remove given-when from opac-search.pl
Bug 14351: Remove given-when from opac-search.pl Bug 14351: Remove given-when from opac-search.pl |
Description
Katrin Fischer
2015-06-06 15:29:26 UTC
Created attachment 39964 [details] [review] Bug 14351: Remove given-when from opac-search.pl Reformats given-when to if-elsif-else in opac-search.pl to remove the experimental feature and with it a lot of warnings from the logs. To test: - Do several different advanced searches with and without expanded search options - Verify the link back to the search appears above the results list and works correctly See also: test plan on bug 13307 Comment on attachment 39964 [details] [review] Bug 14351: Remove given-when from opac-search.pl Review of attachment 39964 [details] [review]: ----------------------------------------------------------------- Lovely code clean up that improves readability! Created attachment 40115 [details] [review] Bug 14351: Remove given-when from opac-search.pl Reformats given-when to if-elsif-else in opac-search.pl to remove the experimental feature and with it a lot of warnings from the logs. To test: - Do several different advanced searches with and without expanded search options - Verify the link back to the search appears above the results list and works correctly See also: test plan on bug 13307 NOTE: Even installed firefox plug in to edit cookies to trigger else case. :) Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Created attachment 40162 [details] [review] Bug 14351: Remove given-when from opac-search.pl Reformats given-when to if-elsif-else in opac-search.pl to remove the experimental feature and with it a lot of warnings from the logs. To test: - Do several different advanced searches with and without expanded search options - Verify the link back to the search appears above the results list and works correctly See also: test plan on bug 13307 NOTE: Even installed firefox plug in to edit cookies to trigger else case. :) Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org> Patch pushed to master. Thanks Katrina! Pushed to 3.20.x will be in 3.20.1 Hi, This patch doesn't apply cleanly to 3.18.x. If you feel it should be included, please provide a version for 3.18.x. Cheers, Liz |