Summary: | Only superlibrarian should see edit links for other branches' items in staff detail | ||
---|---|---|---|
Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
Component: | Cataloging | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | chris, jonathan.druart, liz, m.de.rooy, tomascohen, veron |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14966 | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Bug Depends on: | |||
Bug Blocks: | 15256 | ||
Attachments: |
Bug 14354: Prevent edition of items from other branches if IndependentBranches is on
[Signed-off] Bug 14354: Prevent edition of items from other branches if IndependentBranches is on [PASSED QA] Bug 14354: Prevent edition of items from other branches if IndependentBranches is on |
Description
Katrin Fischer
2015-06-06 21:43:48 UTC
Created attachment 41003 [details] [review] Bug 14354: Prevent edition of items from other branches if IndependentBranches is on If IdependentBranches is ON, to edit/delete items from other branches you need to be superlibrarian. Currently a "simple" staff user cannot edit them from the edit item page but from the catalogue detail page. The edit links should not be displayed on this table. Test plan: O/ Set IndependentBranches to "Prevent". Create a record and add 2 items: Set homebranch to L1 for item I1. Set homebranch to L2 for item I2. 1/ With a superlibrarian user, you should be able to edit both items. 2/ With a "simple" user attached to L1, you should only be able to edit I1. The edit links should not be displayed for I2. Note that the checkbox is displayed on the catalogue detail page (item list), but on the batch tools, it won't be possible to select non-modifiable items. TODO: Add a server-side check. Indeed it is still possible to edit an item if the user know the url. Created attachment 42334 [details] [review] [Signed-off] Bug 14354: Prevent edition of items from other branches if IndependentBranches is on If IdependentBranches is ON, to edit/delete items from other branches you need to be superlibrarian. Currently a "simple" staff user cannot edit them from the edit item page but from the catalogue detail page. The edit links should not be displayed on this table. Test plan: O/ Set IndependentBranches to "Prevent". Create a record and add 2 items: Set homebranch to L1 for item I1. Set homebranch to L2 for item I2. 1/ With a superlibrarian user, you should be able to edit both items. 2/ With a "simple" user attached to L1, you should only be able to edit I1. The edit links should not be displayed for I2. Note that the checkbox is displayed on the catalogue detail page (item list), but on the batch tools, it won't be possible to select non-modifiable items. TODO: Add a server-side check. Indeed it is still possible to edit an item if the user know the url. Followed test plan. Works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Created attachment 42362 [details] [review] [PASSED QA] Bug 14354: Prevent edition of items from other branches if IndependentBranches is on If IdependentBranches is ON, to edit/delete items from other branches you need to be superlibrarian. Currently a "simple" staff user cannot edit them from the edit item page but from the catalogue detail page. The edit links should not be displayed on this table. Test plan: O/ Set IndependentBranches to "Prevent". Create a record and add 2 items: Set homebranch to L1 for item I1. Set homebranch to L2 for item I2. 1/ With a superlibrarian user, you should be able to edit both items. 2/ With a "simple" user attached to L1, you should only be able to edit I1. The edit links should not be displayed for I2. Note that the checkbox is displayed on the catalogue detail page (item list), but on the batch tools, it won't be possible to select non-modifiable items. TODO: Add a server-side check. Indeed it is still possible to edit an item if the user know the url. Followed test plan. Works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Patch pushed to master. Thanks Jonathan! Pushed to 3.20.x will be in 3.20.4 Pushed to 3.18.x will be in 3.18.11 |