| Summary: | Merge reference selection has no effect when merging authorities. | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Maxime Beaulieu <maxime.beaulieu> |
| Component: | Cataloging | Assignee: | Maxime Beaulieu <maxime.beaulieu> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | chris, eric.begin, m.de.rooy, marjorie.barry-vila, maxime.beaulieu, mtj, philippe.blouin, tomascohen, wizzyrea |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 14387 - Merge reference selection has no effect when merging authorities.
[SIGNED OFF] Bug 14387 - Merge reference selection has no effect when merging authorities. Bug 14387 - Merge reference selection has no effect when merging authorities. |
||
Created attachment 40144 [details] [review] Bug 14387 - Merge reference selection has no effect when merging authorities. This patch swaps the authority records according to the reference record selection. To TEST: Merge two authority records, select the second as merge reference. The reference authority is always the first. Apply the patch. Repeat previous steps, the authority is now merged using the selected reference record. modified: authorities/merge.pl Created attachment 40695 [details] [review] [SIGNED OFF] Bug 14387 - Merge reference selection has no effect when merging authorities. This patch swaps the authority records according to the refenrece record selection. To TEST: Merge two authority records, select the second as merge reference. The reference authority is always the first. Apply the patch. Repeat previous steps, the authority is now merged using the selected reference record. modified: authorities/merge.pl Signed-off-by: Nick Clemens <nick@quecheelibrary.org> Created attachment 40875 [details] [review] Bug 14387 - Merge reference selection has no effect when merging authorities. This patch swaps the authority records according to the refenrece record selection. To TEST: Merge two authority records, select the second as merge reference. The reference authority is always the first. Apply the patch. Repeat previous steps, the authority is now merged using the selected reference record. modified: authorities/merge.pl Signed-off-by: Nick Clemens <nick@quecheelibrary.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Patch pushed to master. Thanks Maxime! Pushed to 3.20.x will be in 3.20.3 Pushed to 3.18.x, will be in 3.18.10. Pushed to 3.16.x, will be in 3.16.14 |
When merging authority records, the merge reference is always set to the first selected record. How to reproduce: 0 Create authorities/reindex if necessary. 1 Search for authorities 2 Click merge on two entries (Keep note of the CLICK order 1&2) 3 Select the second authority (authority 2) as merge reference 4 In the following page: The authid in the tabs are correct. The record data is wrong. First tab is authority 1, second is authority 2. The resulting record is generated using authority 1 as reference. A patch will follow.