| Summary: | Small error in example in SMS.pm | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Eivin Giske Skaaren <eivin> |
| Component: | Staff interface | Assignee: | Eivin Giske Skaaren <eivin> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | trivial | ||
| Priority: | P5 - low | CC: | chris, gmcharlt, liz, mtj, tomascohen |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | String patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Corrected example in SMS.pm to working version with hashref.
[SIGNED-OFF] Bug 14421: Corrected example in SMS.pm to working version with hashref. Bug 14421: Corrected example in SMS.pm to working version with hashref. |
||
Created attachment 40363 [details] [review] Corrected example in SMS.pm to working version with hashref. Created attachment 40384 [details] [review] [SIGNED-OFF] Bug 14421: Corrected example in SMS.pm to working version with hashref. http://bugs.koha-community.org/show_bug.cgi?id=14421 Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Test: 1) Apply patch 2) perldoc C4/SMS.pm 3) Check fixed argument in example Argument is hashref, POD is now right Added additional space on second arg No errors Created attachment 40413 [details] [review] Bug 14421: Corrected example in SMS.pm to working version with hashref. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Test: 1) Apply patch 2) perldoc C4/SMS.pm 3) Check fixed argument in example Argument is hashref, POD is now right Added additional space on second arg No errors Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org> Patch pushed to master. Thanks Eivin, and congratulations for your first patch! Pushed to 3.20.x will be in 3.20.2 Pushed to 3.18.x will be in 3.18.09 Pushed to 3.16.x, will be in 3.16.13 |
The send_sms subroutine needs a hashref so {} should be added to the example.