| Summary: | Use Koha::version() instead of C4::Context->KOHAVERSION | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Mark Tompsett <mtompset> |
| Component: | Architecture, internals, and plumbing | Assignee: | Mark Tompsett <mtompset> |
| Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | jonathan.druart, m.de.rooy, tomascohen |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: |
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9006 http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13876 |
||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | 13758, 13876 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 14427: Use Koha::version instead of C4::Context->KOHAVERSION
Bug 14427: Use Koha::version instead of C4::Context->KOHAVERSION Bug 14427: Use Koha::version instead of C4::Context->KOHAVERSION |
||
|
Description
Mark Tompsett
2015-06-19 17:45:06 UTC
Created attachment 40424 [details] [review] Bug 14427: Use Koha::version instead of C4::Context->KOHAVERSION While testing bug 9006, I discovered this gem in installer/install.pl TEST PLAN --------- 1) back up DB 2) drop db and create db 3) git reset --hard origin/3.20.x 4) run web installer and all sample data 5) git reset --hard origin/master 6) empty your koha intranet error log 7) run web installer to upgrade -- there will be warnings regarding regex around installer/install.pl line 328 or so. grep "\$kohaversion" ~/koha-dev/var/logs/koha-error_log 8) repeat steps 2-6 9) apply this patch 10) run web installer to upgrade -- no regex warnings. grep "\$kohaversion" ~/koha-dev/var/logs/koha-error_log 11) koha qa test tools Also: git grep KOHAVERSION Should only show release notes entry. :) This is because 13876 and 13758 have been written tested more or less at the same time. The only problem is that the generated log file is named updatedatabase_2015-06-22T13:18:26_3.2100009_.log when it should be updatedatabase_2015-06-22T13:23:31_3.2100009_3.2100010.log Created attachment 40458 [details] [review] Bug 14427: Use Koha::version instead of C4::Context->KOHAVERSION While testing bug 9006, I discovered this gem in installer/install.pl TEST PLAN --------- 1) back up DB 2) drop db and create db 3) git reset --hard origin/3.20.x 4) run web installer and all sample data 5) git reset --hard origin/master 6) empty your koha intranet error log 7) run web installer to upgrade -- there will be warnings regarding regex around installer/install.pl line 328 or so. grep "\$kohaversion" ~/koha-dev/var/logs/koha-error_log 8) repeat steps 2-6 9) apply this patch 10) run web installer to upgrade -- no regex warnings. grep "\$kohaversion" ~/koha-dev/var/logs/koha-error_log 11) koha qa test tools Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org> Created attachment 40771 [details] [review] Bug 14427: Use Koha::version instead of C4::Context->KOHAVERSION While testing bug 9006, I discovered this gem in installer/install.pl TEST PLAN --------- 1) back up DB 2) drop db and create db 3) git reset --hard origin/3.20.x 4) run web installer and all sample data 5) git reset --hard origin/master 6) empty your koha intranet error log 7) run web installer to upgrade -- there will be warnings regarding regex around installer/install.pl line 328 or so. grep "\$kohaversion" ~/koha-dev/var/logs/koha-error_log 8) repeat steps 2-6 9) apply this patch 10) run web installer to upgrade -- no regex warnings. grep "\$kohaversion" ~/koha-dev/var/logs/koha-error_log 11) koha qa test tools Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Patch pushed to master. Thanks Mark! |