| Summary: | Resolve "Use of uninitialized value in goto" in admin/preferences.pl | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Aleisha Amohia <aleisha> |
| Component: | System Administration | Assignee: | Marcel de Rooy <m.de.rooy> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | trivial | ||
| Priority: | P5 - low | CC: | fridolin.somers, gmcharlt, jonathan.druart, m.de.rooy, marianm, martin.renvoize, nick |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 14446: Workaround to resolve uninitialized value in goto warning
[SIGNED-OFF] Bug 14446: Workaround to resolve uninitialized value in goto warning Bug 14446: Workaround to resolve uninitialized value in goto warning |
||
|
Description
Aleisha Amohia
2015-06-24 04:51:30 UTC
It comes from the null option of the OpacRenewalBranch pref. I also have this problem did you have found a fix for it ? Created attachment 76685 [details] [review] Bug 14446: Workaround to resolve uninitialized value in goto warning Forcing both GetTab calls to list context resolves the warning. A workaround, not a real fix. Test plan: Search for something in the syspref text bar. Without this patch, you will have a warn: Use of uninitialized value in goto With this patch, you won't. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 76712 [details] [review] [SIGNED-OFF] Bug 14446: Workaround to resolve uninitialized value in goto warning Forcing both GetTab calls to list context resolves the warning. A workaround, not a real fix. Test plan: Search for something in the syspref text bar. Without this patch, you will have a warn: Use of uninitialized value in goto With this patch, you won't. Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> Thx Aleisha.
For QA:
The workaround is based on the fact that YAML::Syck contains this code:
sub Load {
if (wantarray) {
my ($rv) = YAML::Syck::LoadYAML( $_[0] );
@{$rv};
}
else {
@_ = $_[0];
goto &YAML::Syck::LoadYAML;
}
}
Created attachment 76756 [details] [review] Bug 14446: Workaround to resolve uninitialized value in goto warning Forcing both GetTab calls to list context resolves the warning. A workaround, not a real fix. Test plan: Search for something in the syspref text bar. Without this patch, you will have a warn: Use of uninitialized value in goto With this patch, you won't. Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Awesome work all! Pushed to master for 18.11 Pushed to 18.05.x for 18.05.02 Pushed to 17.11.x for 17.11.09 I choose not to push to 17.05.x |