| Summary: | Broken umlauts/diacritics in feedback of last checkout | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
| Component: | Circulation | Assignee: | Kyle M Hall (khall) <kyle> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | major | ||
| Priority: | P5 - low | CC: | amitddng135, bgkriegel, gmcharlt, kyle.m.hall, kyle, liz, mtj |
| Version: | 3.18 | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | 13315 | ||
| Bug Blocks: | |||
| Attachments: |
Screenshot showing the problem
Bug 14465 - Broken umlauts/diacritics in feedback of last checkout Bug 14465 - Broken umlauts/diacritics in feedback of last checkout [SIGNED-OFF] Bug 14465 - Broken umlauts/diacritics in feedback of last checkout [PASSED QA][3.18.x] Bug 14465 - Broken umlauts/diacritics in feedback of last checkout |
||
|
Description
Katrin Fischer
2015-06-26 11:23:37 UTC
Created attachment 40651 [details] [review] Bug 14465 - Broken umlauts/diacritics in feedback of last checkout This was tested in 3.18 after upgrading to the security release. The feedback on the last checkout information introcuded by bug 13315 has encoding problems in the displayed title (see screenshot). This is a really prominent place to display broken encoding. Test Plan: 1) Apply this patch 2) Check out an item with broken encoding 3) Note the title now displays properly Commit Body is: -------------------------- Bug 14465 - Broken umlauts/diacritics in feedback of last checkout This was tested in 3.18 after upgrading to the security release. The feedback on the last checkout information introcuded by bug 13315 has encoding problems in the displayed title (see screenshot). This is a really prominent place to display broken encoding. Test Plan: 1) Apply this patch 2) Check out an item with broken encoding 3) Note the title now displays properly -------------------------- Apply? [y]es/[n]o/[e]dit/[v]iew patch/[a]ccept all a Applying: Bug 14465 - Broken umlauts/diacritics in feedback of last checkout Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt Failed to merge in the changes. Patch failed at 0001 Bug 14465 - Broken umlauts/diacritics in feedback of last checkout When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort". (In reply to Amit from comment #2) > Patch failed at 0001 Bug 14465 - Broken umlauts/diacritics in feedback of It's for 3.18.x branch oh! sorry will test on 3.18.x Created attachment 40655 [details] [review] Bug 14465 - Broken umlauts/diacritics in feedback of last checkout This was tested in 3.18 after upgrading to the security release. The feedback on the last checkout information introcuded by bug 13315 has encoding problems in the displayed title (see screenshot). This is a really prominent place to display broken encoding. Test Plan: 1) Apply this patch 2) Check out an item with broken encoding 3) Note the title now displays properly Created attachment 40656 [details] [review] [SIGNED-OFF] Bug 14465 - Broken umlauts/diacritics in feedback of last checkout This was tested in 3.18 after upgrading to the security release. The feedback on the last checkout information introcuded by bug 13315 has encoding problems in the displayed title (see screenshot). This is a really prominent place to display broken encoding. Test Plan: 1) Apply this patch 2) Check out an item with broken encoding 3) Note the title now displays properly Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Works well, no errors (In reply to Amit from comment #4) > oh! sorry will test on 3.18.x I win :) (In reply to Bernardo Gonzalez Kriegel from comment #7) > (In reply to Amit from comment #4) > > oh! sorry will test on 3.18.x > > I win :) No, you did, I'll obsolete my patch Regards Created attachment 40679 [details] [review] [PASSED QA][3.18.x] Bug 14465 - Broken umlauts/diacritics in feedback of last checkout This was tested in 3.18 after upgrading to the security release. The feedback on the last checkout information introcuded by bug 13315 has encoding problems in the displayed title (see screenshot). This is a really prominent place to display broken encoding. Test Plan: 1) Apply this patch 2) Check out an item with broken encoding 3) Note the title now displays properly Signed-off-by: Amit Gupta <amit.gupta@informaticsglobal.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> We already put it in production... so this better works :) This one is only for 3.18.x! Pushed to 3.18.x will be in 3.18.10. |