|
Description
Claudio Costales
2015-06-28 17:15:29 UTC
Created attachment 40706 [details]
step-by-step sample
Katrin, do you agree this is a bug? I think if we block renewals in the staff client, we should do the same in OPAC - normally staff client allows more than OPAC, the opposite behaviour seems unexpected. (In reply to Katrin Fischer from comment #3) > I think if we block renewals in the staff client, we should do the same in > OPAC - normally staff client allows more than OPAC, the opposite behaviour > seems unexpected. Katrin, despite of your comment (that I agree), the behaviour in staff, as I understand, is the correct behaviour. I think we are not disagreeing - I think the OPAC should also block renewals in this case if it was designed to do so in staff. It doesn't make sense to treat both separately. It would be nice if there was also a way to define the number of renewals possible for on-site-checkouts in the future. (In reply to Katrin Fischer from comment #5) > I think we are not disagreeing - I think the OPAC should also block renewals > in this case if it was designed to do so in staff. It doesn't make sense to > treat both separately. It would be nice if there was also a way to define > the number of renewals possible for on-site-checkouts in the future. That was the meaning of my comment. I agree with you. Sorry if there was a misunderstanding. Created attachment 41336 [details] [review] Bug 14470: Do not allow renew for on-site checkouts At the opac, the renew checkbox should not be displayed if it's an on-site checkout (same on the intranet). On the way, this patch adds a specific message to the intranet if the librarian try to renew an on-site checkout. Indeed before this patch a renew was allowed if the barcode was scanned. Test plan: 1/ Create an on-site checkout for a patron 2/ Confirm that the checkbox 'renew' is not displayed on the checkout list tables 3/ At the OPAC, the renew should not be allowed (no checkbox) 4/ Try to check the item out to the same patron, confirm that you get a specifig message to inform you the renew is not allowed for on-site checkouts. Jonathan, I was testing in a local installation. All works fine if I discard checkout.js modifications. If I consider checkout.js modifications all checkouts in the checkout patron view are missing. Please see attached PDF. Created attachment 41430 [details]
Missing data display in checkout patron view
It seems to work here. Are you sure you have correctly refreshed the page (to take into account the JS changes)? You certainly got a JS error, please report it here. You are wright Jonathan, I'm soooooo sorry. All work fine, great job! I've attached a PDF file with some legends suggestions. Thank you very much Jonathan! Created attachment 41440 [details]
Legends suggestions
Created attachment 41444 [details] [review] Bug 14470: Do not allow renew for on-site checkouts At the opac, the renew checkbox should not be displayed if it's an on-site checkout (same on the intranet). On the way, this patch adds a specific message to the intranet if the librarian try to renew an on-site checkout. Indeed before this patch a renew was allowed if the barcode was scanned. Test plan: 1/ Create an on-site checkout for a patron 2/ Confirm that the checkbox 'renew' is not displayed on the checkout list tables 3/ At the OPAC, the renew should not be allowed (no checkbox) 4/ Try to check the item out to the same patron, confirm that you get a specifig message to inform you the renew is not allowed for on-site checkouts. Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> The display is not consistent. I observed: OPAC (opac-user.pl, column »Renew«) before patch (if renewal allowed according to circ matrix): »[checkbox] Renew (x of x renewals remaining)« before patch (if renewal not allowed): »[no checkbox] Not renewable« after patch: [empty] Staff (Checkouts, tab »Check out«, column »Renew«) before patch (if renewal allowed): »0« before patch (if renewal not allowed): »0 Not renewable« after patch: »0« OPAC should display no checkbox, but the message »Not renewable«, as it does if renewal is not allowed for other reasons. Staff should display »Not renewable« It's fine for me. Patch doesn't apply due to a conflict in Circulation.t - can you please fix? Created attachment 42195 [details] [review] Bug 14470: Do not allow renew for on-site checkouts At the opac, the renew checkbox should not be displayed if it's an on-site checkout (same on the intranet). On the way, this patch adds a specific message to the intranet if the librarian try to renew an on-site checkout. Indeed before this patch a renew was allowed if the barcode was scanned. Test plan: 1/ Create an on-site checkout for a patron 2/ Confirm that the checkbox 'renew' is not displayed on the checkout list tables 3/ At the OPAC, the renew should not be allowed (no checkbox) 4/ Try to check the item out to the same patron, confirm that you get a specifig message to inform you the renew is not allowed for on-site checkouts. Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Created attachment 42365 [details] [review] [PASSED QA] Bug 14470: Do not allow renew for on-site checkouts At the opac, the renew checkbox should not be displayed if it's an on-site checkout (same on the intranet). On the way, this patch adds a specific message to the intranet if the librarian try to renew an on-site checkout. Indeed before this patch a renew was allowed if the barcode was scanned. Test plan: 1/ Create an on-site checkout for a patron 2/ Confirm that the checkbox 'renew' is not displayed on the checkout list tables 3/ At the OPAC, the renew should not be allowed (no checkbox) 4/ Try to check the item out to the same patron, confirm that you get a specifig message to inform you the renew is not allowed for on-site checkouts. Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Changed 'issue' to 'item' in the error message. This is good - but I agree with bondiurbano - we should really mark the on-site checkouts in the checkouts list, maybe similar to how it is in the staff client. It's visible in the reading history only. Created attachment 42366 [details] [review] [PASSED QA] Bug 14470: Do not allow renew for on-site checkouts At the opac, the renew checkbox should not be displayed if it's an on-site checkout (same on the intranet). On the way, this patch adds a specific message to the intranet if the librarian try to renew an on-site checkout. Indeed before this patch a renew was allowed if the barcode was scanned. Test plan: 1/ Create an on-site checkout for a patron 2/ Confirm that the checkbox 'renew' is not displayed on the checkout list tables 3/ At the OPAC, the renew should not be allowed (no checkbox) 4/ Try to check the item out to the same patron, confirm that you get a specifig message to inform you the renew is not allowed for on-site checkouts. Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Changed 'issue' to 'item' in the error message. Patch pushed to master. Thanks Jonathan! Thanks to all! Pushed to 3.20.x will be in 3.20.4 Pushed to 3.18.x will be in 3.18.11 |