Bug 14538

Summary: POD for CalcFine is incomplete
Product: Koha Reporter: Katrin Fischer <katrin.fischer>
Component: Developer documentationAssignee: natasha <tasham_8>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: minor    
Priority: P5 - low CC: chris, f.demians, jonathan.druart, julian.maurice, jweaver
Version: MainKeywords: Academy
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:
Attachments: Bug 14538: editing perl doc for CalcFine
Bug 14538: editing perl doc for CalcFine
Bug 14538: editing perl doc for CalcFine

Description Katrin Fischer 2015-07-16 12:55:53 UTC
From reading the code it looks like CalcFine returns 4 values, while only 3 are documented (missing:chargeable_units). There is also a mismatch in names between the first and second paragraphs ($daycounttotal vs. $unitcount)
Comment 1 natasha 2016-01-18 23:02:28 UTC Comment hidden (obsolete)
Comment 2 Mark Tompsett 2016-01-19 16:23:57 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2016-01-19 16:33:01 UTC
Created attachment 46909 [details] [review]
Bug 14538: editing perl doc for CalcFine

To Test:
Read perldoc C4/Overdues.pm
Confirm that it says CalcFine returns four values and that rest of the documentation is correct

NOTE: only a little visual ugliness, but definitely an improvement.

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 4 Jesse Weaver 2016-01-19 22:50:11 UTC
Pushed to master, thanks for your work!
Comment 5 Julian Maurice 2016-01-25 12:21:47 UTC
Patch pushed to 3.22.x, will be in 3.22.2
Comment 6 Frédéric Demians 2016-01-25 16:28:52 UTC
This patch has been pushed to 3.20.x, will be in 3.20.8.