| Summary: | Warns when clearing a rating on an item on OPAC | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Aleisha Amohia <aleisha> |
| Component: | OPAC | Assignee: | Aleisha Amohia <aleisha> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | f.demians, jonathan.druart, liz, tomascohen |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 14553: Silencing warn triggered when clearing item rating on OPAC
Bug 14553: Silencing warn triggered when clearing item rating on OPAC Bug 14553: Silencing warn triggered when clearing item rating on OPAC |
||
|
Description
Aleisha Amohia
2015-07-17 03:48:34 UTC
Created attachment 41114 [details] [review] Bug 14553: Silencing warn triggered when clearing item rating on OPAC To test: 1) Go to any item and clear the star rating (don't have to set a rating first) 2) Notice the warn 3) Apply patch and reload page 4) Clear star rating 5) Notice no warn 6) Click a star to add a rating 7) Make sure your rating, the average rating and amount of votes are all correct 8) Could be beneficial to log in as another user and try to add a rating on the same item from their account. Check the average rating is cacalculated and amount of votes increases 9) Confirm still no warns Created attachment 44748 [details] [review] Bug 14553: Silencing warn triggered when clearing item rating on OPAC To test: 1) Go to any item and clear the star rating (don't have to set a rating first) 2) Notice the warn 3) Apply patch and reload page 4) Clear star rating 5) Notice no warn 6) Click a star to add a rating 7) Make sure your rating, the average rating and amount of votes are all correct 8) Could be beneficial to log in as another user and try to add a rating on the same item from their account. Check the average rating is cacalculated and amount of votes increases 9) Confirm still no warns Signed-off-by: Frederic Demians <f.demians@tamil.fr> Can see the warning in logs, and its disappearance with this patch. Created attachment 44759 [details] [review] Bug 14553: Silencing warn triggered when clearing item rating on OPAC To test: 1) Go to any item and clear the star rating (don't have to set a rating first) 2) Notice the warn 3) Apply patch and reload page 4) Clear star rating 5) Notice no warn 6) Click a star to add a rating 7) Make sure your rating, the average rating and amount of votes are all correct 8) Could be beneficial to log in as another user and try to add a rating on the same item from their account. Check the average rating is cacalculated and amount of votes increases 9) Confirm still no warns Signed-off-by: Frederic Demians <f.demians@tamil.fr> Can see the warning in logs, and its disappearance with this patch. Patch pushed to master. Thanks Aleisha! This patch has been pushed to 3.20.x, will be in 3.20.6. Pushed to 3.18.13, and released. |