| Summary: | 'You are not logged in' should link to log in page | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Aleisha Amohia <aleisha> |
| Component: | Staff interface | Assignee: | Aleisha Amohia <aleisha> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | chris, cnorthcott.work, gmcharlt, jonathan.druart, liz, tomascohen |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14773 | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 14579: 'You are not logged in' should link to log in page
Bug 14579: 'You are not logged in' should link to log in page Bug 14579: 'You are not logged in' should link to log in page Bug 14579: 'You are not logged in' should link to log in page |
||
|
Description
Aleisha Amohia
2015-07-21 03:48:48 UTC
Created attachment 41106 [details] [review] Bug 14579: 'You are not logged in' should link to log in page To test: 1) Go to any page on the staff client and make sure you are not logged in (ie an error page, cgi-bin/koha/errors/400.pl) 2) Try click on 'You are not logged in |' 3) Notice it is not really a link and doesn't take you anywhere 4) Apply patch 5) Refresh page 6) Click on what now says 'Log in |' 7) Confirm that you are redirected to the intranet log in page Patch applies, link now works but alignment of Log In text and Help text are mismatched. (In reply to cnorthcott.work from comment #2) > Patch applies, link now works but alignment of Log In text and Help text are > mismatched. Aleisha, could you try to fix the alignment? Created attachment 41658 [details] [review] Bug 14579: 'You are not logged in' should link to log in page I fixed the aligment of the two links but the padding still needs to be set right. I also fixed mismatching html tags. To test: 1) Go to any page on the staff client and make sure you are not logged in (ie an error page, cgi-bin/koha/errors/400.pl) 2) Try click on 'You are not logged in |' 3) Notice it is not really a link and doesn't take you anywhere 4) Apply patch 5) Refresh page 6) Click on what now says 'Log in |' 7) Confirm that you are redirected to the intranet log in page Created attachment 42004 [details] [review] Bug 14579: 'You are not logged in' should link to log in page To test: 1) Go to any page on the staff client and make sure you are not logged in (ie an error page, cgi-bin/koha/errors/400.pl) 2) Try click on 'You are not logged in |' 3) Notice it is not really a link and doesn't take you anywhere 4) Apply patch 5) Refresh page 6) Click on what now says 'Log in |' 7) Confirm that you are redirected to the intranet log in page Signed-off-by: Aleisha <aleishaamohia@hotmail.com> Created attachment 42008 [details] [review] Bug 14579: 'You are not logged in' should link to log in page To test: 1) Go to any page on the staff client and make sure you are not logged in (ie an error page, cgi-bin/koha/errors/400.pl) 2) Try click on 'You are not logged in |' 3) Notice it is not really a link and doesn't take you anywhere 4) Apply patch 5) Refresh page 6) Click on what now says 'Log in |' 7) Confirm that you are redirected to the intranet log in page Signed-off-by: Aleisha <aleishaamohia@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Patch pushed to master. Thanks Joonas, and congratulations for your first commit in Koha! This patch moved the help menu from the top right, next to the login menu to inside the dropdown. I don't think we want to hide it like that. Liz Liz, it's the same place as when you are logged in. What do you suggest? I'll make a different bug :) Pushed to 3.20.x will be in 3.20.4 |