Description
Jesse Weaver
2015-07-27 21:01:54 UTC
Created attachment 41393 [details] [review] Bug 14607: Baker & Taylor cover images should be accessible by UPC as well as ISBN Test plan (requires Baker and Taylor cover images to be set up and enabled): 1. Create a record with an ISBN that does not have a cover and a UPC that does. 141985934X/085391174929 is one set that works well. 2. Verify that the record shows up as "No image available" in the following OPAC locations: shelf browser, reviews, lists, search and reading record. This will require adding reviews/checkouts/etc. for the record in question. 3. Apply patch. 4. Check the locations again, and verify that the record now has a valid cover image. Created attachment 41633 [details] [review] Bug 14607: Baker & Taylor cover images should be accessible by UPC as well as ISBN Test plan (requires Baker and Taylor cover images to be set up and enabled): 1. Create a record with an ISBN that does not have a cover and a UPC that does. 141985934X/085391174929 is one set that works well. 2. Verify that the record shows up as "No image available" in the following OPAC locations: shelf browser, reviews, lists, search and reading record. This will require adding reviews/checkouts/etc. for the record in question. 3. Apply patch. 4. Check the locations again, and verify that the record now has a valid cover image. Signed-off-by: Alexis Rodegerdts <arodegerdts@wallawallawa.gov> Comment on attachment 41633 [details] [review] Bug 14607: Baker & Taylor cover images should be accessible by UPC as well as ISBN Review of attachment 41633 [details] [review]: ----------------------------------------------------------------- ::: koha-tmpl/opac-tmpl/bootstrap/en/includes/shelfbrowser.inc @@ +58,4 @@ > <div title="[% item.biblionumber |url %]" class="[% coce_id %]" id="coce-thumbnail-preview-[% coce_id %]"></div> > [% END %] > [% IF ( BakerTaylorEnabled ) %] > + [% bt_id = ( item.browser_normalized_upc || item.browser_normalized_upc ) %] This does not make any sense :) Created attachment 42253 [details] [review] Bug 14607: (QA followup) Fix typo in shelfbrowser.inc Jesse, I cannot test this patch, I don't have a B&T account. But looking at the code I am wondering if there is not another occurrence to update: opac-user.tt l.414 <a href="https://[% BakerTaylorBookstoreURL |html %][% OVERDUE.normalized_isbn %]"><img alt="See Baker & Taylor" src="[% BakerTaylorImageURL |html %][% OVERDUE.normalized_isbn %]" /></a> Created attachment 42547 [details] [review] Bug 14607: (QA followup) Fix one missing occurence, incorrect calls to GetNormalizedUPC Jesse, since I cannot test the patch, I would like to get a signoff on the 2 last patches. Created attachment 43018 [details] [review] Bug 14607: (QA followup) Fix typo in shelfbrowser.inc Signed-off-by: Alexis Rodegerdts <arodegerdts@wallawallawa.gov> Created attachment 43019 [details] [review] Bug 14607: (QA followup) Fix one missing occurence, incorrect calls to GetNormalizedUPC Signed-off-by: Alexis Rodegerdts <arodegerdts@wallawallawa.gov> Created attachment 43157 [details] [review] Bug 14607: Baker & Taylor cover images should be accessible by UPC as well as ISBN Test plan (requires Baker and Taylor cover images to be set up and enabled): 1. Create a record with an ISBN that does not have a cover and a UPC that does. 141985934X/085391174929 is one set that works well. 2. Verify that the record shows up as "No image available" in the following OPAC locations: shelf browser, reviews, lists, search and reading record. This will require adding reviews/checkouts/etc. for the record in question. 3. Apply patch. 4. Check the locations again, and verify that the record now has a valid cover image. Signed-off-by: Alexis Rodegerdts <arodegerdts@wallawallawa.gov> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 43158 [details] [review] Bug 14607: (QA followup) Fix typo in shelfbrowser.inc Signed-off-by: Alexis Rodegerdts <arodegerdts@wallawallawa.gov> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 43159 [details] [review] Bug 14607: (QA followup) Fix one missing occurence, incorrect calls to GetNormalizedUPC Signed-off-by: Alexis Rodegerdts <arodegerdts@wallawallawa.gov> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Patches pushed to master. Thanks Jesse! |