| Summary: | Add indexes for MARC 020$z => ISBN, 022$y, 022$z => ISSN | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Barton Chittenden <barton> |
| Component: | Searching | Assignee: | Barton Chittenden <barton> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | jonathan.druart, jschmidt, tomascohen |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11653 | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Add fields to ISBN and ISSN indexes: 020$z, 022$y, 022$z
[SIGNED-OFF] Bug 14617: Add fields to ISBN and ISSN indexes: 020$z, 022$y, 022$z Bug 14617: Add fields to ISBN and ISSN indexes: 020$z, 022$y, 022$z Bug 14617: Add fields to ISBN and ISSN indexes: 020$z, 022$y, 022$z |
||
|
Description
Barton Chittenden
2015-07-29 14:42:07 UTC
What index will u use? I'd suggest reusing the Tomas, I'm planning on re-using the existing ISBN and ISSN indexes -- I'm simply looking to extend what's there, and I don't want to mess around with the bib1 and ccl configuration. Yeah, I was about to discard my message (hence its incompleteness) but clicked to be cc-ed by this bug and it applied my comment :-D Created attachment 41429 [details] [review] Add fields to ISBN and ISSN indexes: 020$z, 022$y, 022$z Created attachment 42607 [details] [review] [SIGNED-OFF] Bug 14617: Add fields to ISBN and ISSN indexes: 020$z, 022$y, 022$z http://bugs.koha-community.org/show_bug.cgi?id=14617 Signed-off-by: kholten@switchinc.org Comment on attachment 41429 [details] [review] Add fields to ISBN and ISSN indexes: 020$z, 022$y, 022$z Obsoleted by following patch. Just to be clear, this is ready for QA. Barton, you should fix the author's patch. (In reply to Jonathan Druart from comment #8) > Barton, you should fix the author's patch. Jonathan, I don't think that there's anything wrong with the patch ... I signed off on the patch for our partner library [we ran a demo for them], and I forgot to obsolete the un-signed patch when I submitted it. Test plan: 1) Import MARC21 bibs containing - ISBN in 020$z - ISSN in 022$y - ISSN in 022$z 2) Make sure that bibs are indexed 3) Search by ISBN and ISSN above -- bibs should not show in search. 4) Apply patch, re-index 5) Search again; ISBN in 020$z and ISSN in 022$y and 022$z should return results. (In reply to Barton Chittenden from comment #9) > (In reply to Jonathan Druart from comment #8) > > Barton, you should fix the author's patch. > > Jonathan, > > I don't think that there's anything wrong with the patch ... I signed off on > the patch for our partner library [we ran a demo for them], and I forgot to > obsolete the un-signed patch when I submitted it. The author's patch is "From: Koha instance bug_14617-koha <bug_14617-koha@bwsdev.bywatersolutions.com>" Created attachment 43171 [details] [review] Bug 14617: Add fields to ISBN and ISSN indexes: 020$z, 022$y, 022$z http://bugs.koha-community.org/show_bug.cgi?id=14617 Signed-off-by: kholten@switchinc.org (In reply to Jonathan Druart from comment #10) > (In reply to Barton Chittenden from comment #9) > > (In reply to Jonathan Druart from comment #8) > > > Barton, you should fix the author's patch. > > > > Jonathan, > > > > I don't think that there's anything wrong with the patch ... I signed off on > > the patch for our partner library [we ran a demo for them], and I forgot to > > obsolete the un-signed patch when I submitted it. > > The author's patch is "From: Koha instance bug_14617-koha > <bug_14617-koha@bwsdev.bywatersolutions.com>" Fixed author of patch. (In reply to Barton Chittenden from comment #12) > (In reply to Jonathan Druart from comment #10) > > > > The author's patch is "From: Koha instance bug_14617-koha > > <bug_14617-koha@bwsdev.bywatersolutions.com>" > > Fixed author of patch. Jonathan, can you take a quick look at this? I fixed the 'author' and 'email' on the patch. Thanks, --Barton Created attachment 43422 [details] [review] Bug 14617: Add fields to ISBN and ISSN indexes: 020$z, 022$y, 022$z 1) Import MARC21 bibs containing - ISBN in 020$z - ISSN in 022$y - ISSN in 022$z 2) Make sure that bibs are indexed 3) Search by ISBN and ISSN above -- bibs should not show in search. 4) Apply patch, re-index 5) Search again; ISBN in 020$z and ISSN in 022$y and 022$z should return results. Signed-off-by: kholten@switchinc.org Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Patch pushed to master. Thanks Barton! |