|
Description
Francois Charbonnier
2015-07-30 19:07:29 UTC
Created attachment 41242 [details] [review] Bug 14622 - New data in French Canadian for the web installer. Add "fr-CA" folder. TEST PLAN : - install Koha - choose fr-CA as the installation language - check every options in the web installer - every file should load smoothly How did you generate this list? Be care, userpermissions.sq is not up-to-date. Why did you create fr-CA/obligatoire? (we have a fr-FR/1-Obligatoire). Hi Jonathan, How did you generate this list? - I checked what the english folder had Be care, userpermissions.sq is not up-to-date. - I will check this (but did this file change since 3.20.0?) Why did you create fr-CA/obligatoire? (we have a fr-FR/1-Obligatoire). - Because, when installing in fr-CA, the installer will not check in the fr-FR folder. (In reply to Francois Charbonnier from comment #3) > Hi Jonathan, > > How did you generate this list? > - I checked what the english folder had > > Be care, userpermissions.sq is not up-to-date. > - I will check this (but did this file change since 3.20.0?) No, but 3.20 has delete_public_lists. > Why did you create fr-CA/obligatoire? (we have a fr-FR/1-Obligatoire). > - Because, when installing in fr-CA, the installer will not check in the > fr-FR folder. Yes of course, but why not fr-CA/1-Obligatoire? I don't care, just want to know :) Created attachment 41742 [details] [review] BZ14622 - follow up - missing userpermissions added I sent a new patch to fix the missing userpermission About the 1-Obligatoire, I actually used some translation from fr-FR and updated others as well. Just so you know, not all files are translated in the fr-FR folder (for example,numberpattern.pl). Plus, I wanted the letters to be all formated the same way and there are "mandatory" authorised values that are not considered mandatory in the other folders. I wanted the fr-CA to be as close as the other folders (same stucure, same content, etc.) The only differences are in the marc21 framework default sql. Testing with fr-CA translation When importing data into db: userpermissions.sql ERROR 1452 (23000) at line 1: Cannot add or update a child row: a foreign key constraint fails (`kohadev`.`permissions`, CONSTRAINT `permissions_ibfk_1` FOREIGN KEY (`module_bit`) REFERENCES `userflags` (`bit`) ON DELETE CASCADE ON UPDATE CASCADE) sample_creator_data.sql ERROR 1136 (21S01) at line 6: Column count doesn't match value count at row 1 this is fixed in Bug 15053, check the solution sample_patrons.sql ERROR 1054 (42S22) at line 1: Unknown column 'ethnicity' in 'field list' I wrote an email to you about frameworks. Created attachment 48378 [details] [review] Bug 14622 - New data in French Canadian for the web installer. Add "fr-CA" folder. TEST PLAN : - install Koha - choose fr-CA as the installation language - check every options in the web installer - every file should load smoothly I fixed the issues reported by Bernado. Changed a couple of things to fit master (remove stopwords.sql, etc.) And reloaded everyting on a local master installation Bernado, I followed your advices on the frameworks sql. Now, they are similar to the other frameworks. Created attachment 50904 [details] [review] [SIGNED-OFF] Bug 14622 - New data in French Canadian for the web installer. Add "fr-CA" folder. TEST PLAN : - install Koha - choose fr-CA as the installation language - check every options in the web installer - every file should load smoothly Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Works well, no problem/warning loading all sample files. No koha-qa errors Created attachment 50924 [details] [review] Bug 14622 - New data in French Canadian for the web installer. Add "fr-CA" folder. TEST PLAN : - install Koha - choose fr-CA as the installation language - check every options in the web installer - every file should load smoothly Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Works well, no problem/warning loading all sample files. No koha-qa errors Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Pushed to master for Koha 16.05, thanks Francois! |