Description
Katrin Fischer
2015-07-31 07:57:28 UTC
The documentation of the script and how it works don't match up - we should fix the documentation. Created attachment 46843 [details] [review] Bug 14624 - <<items.content>> for advance_notices.pl wrongly documented To Test Check perldoc for misc/cronjobs/advance_noitces.pl and see that the documentation matches. Bug 9499 failed to document it correctly in both places. Line 104 was correct, but line 147 is not. This patch visually fixes that. Created attachment 47068 [details] [review] Bug 14624 - <<items.content>> for advance_notices.pl wrongly documented To Test Check perldoc for misc/cronjobs/advance_noitces.pl and see that the documentation matches. Ran: $ perldoc misc/cronjobs/advance_noitces.pl Saw expected changes. Koha QA test tools pass too. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Created attachment 47173 [details] [review] Bug 14624 - <<items.content>> for advance_notices.pl wrongly documented To Test Check perldoc for misc/cronjobs/advance_noitces.pl and see that the documentation matches. Ran: $ perldoc misc/cronjobs/advance_noitces.pl Saw expected changes. Koha QA test tools pass too. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Switched due date for the name of the database column date_due as the parameter expects a list of database column names. Created attachment 47174 [details] [review] Bug 14624 - <<items.content>> for advance_notices.pl wrongly documented To Test Check perldoc for misc/cronjobs/advance_noitces.pl and see that the documentation matches. Ran: $ perldoc misc/cronjobs/advance_noitces.pl Saw expected changes. Koha QA test tools pass too. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Switched due date for the name of the database column date_due as the parameter expects a list of database column names. Pushed to Master - Should be in the may 2016 release. Thanks! Patch pushed to 3.22.x, will be in 3.22.3 This patch has been pushed to 3.20.x, will be in 3.20.9. |