|
Description
Fridolin Somers
2015-08-06 08:27:59 UTC
Created attachment 41399 [details] [review] Bug 14653 - Acq planning filter always use default active period In Acq planning /cgi-bin/koha/admin/aqplan.pl, left side filter and export forms have no parameter budget_period_id nor authcat, so the use the default active period. As said in code : - IF PERIOD_ID IS DEFINED, GET THE PERIOD - ELSE GET THE ACTIVE PERIOD BY DEFAULT my $period = GetBudgetPeriod($budget_period_id); This patch corrects the filter form. Test plan : - Create an active budget "B_ACTIVE" with 1 fund - Create an inactive budget "B_OLD" with 3 funds - Go to "B_OLD" planning by libraries - You see 3 funds - In filter form, select "by months" in "Select planning type" => Without patch, you see planning of "B_ACTIVE" with 1 fund => Without patch, you see planning of "B_OLD" with 3 funds Created attachment 41400 [details] [review] Bug 14653 - Acq planning export always use default active period In Acq planning /cgi-bin/koha/admin/aqplan.pl, left side filter and export forms have no parameter budget_period_id nor authcat, so the use the default active period. As said in code - IF PERIOD_ID IS DEFINED, GET THE PERIOD - ELSE GET THE ACTIVE PERIOD BY DEFAULT my $period = GetBudgetPeriod($budget_period_id); This patch corrects the export form. Test plan : - Create an active budget "B_ACTIVE" with 1 fund - Create an inactive budget "B_OLD" with 3 funds - Go to "B_OLD" planning by libraries - You see 3 funds - Click on "Submit" in export form => Without patch, you get the planning of "B_ACTIVE" with 1 fund => Without patch, you get the planning of "B_OLD" with 3 funds by libraries Created attachment 43307 [details] [review] [SIGNED-OFF]Bug 14653 - Acq planning export always use default active period In Acq planning /cgi-bin/koha/admin/aqplan.pl, left side filter and export forms have no parameter budget_period_id nor authcat, so the use the default active period. As said in code - IF PERIOD_ID IS DEFINED, GET THE PERIOD - ELSE GET THE ACTIVE PERIOD BY DEFAULT my $period = GetBudgetPeriod($budget_period_id); This patch corrects the export form. Test plan : - Create an active budget "B_ACTIVE" with 1 fund - Create an inactive budget "B_OLD" with 3 funds - Go to "B_OLD" planning by libraries - You see 3 funds - Click on "Submit" in export form => Without patch, you get the planning of "B_ACTIVE" with 1 fund => Without patch, you get the planning of "B_OLD" with 3 funds by libraries Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised Created attachment 43308 [details] [review] [SIGNED-OFF]Bug 14653 - Acq planning filter always use default active period In Acq planning /cgi-bin/koha/admin/aqplan.pl, left side filter and export forms have no parameter budget_period_id nor authcat, so the use the default active period. As said in code : - IF PERIOD_ID IS DEFINED, GET THE PERIOD - ELSE GET THE ACTIVE PERIOD BY DEFAULT my $period = GetBudgetPeriod($budget_period_id); This patch corrects the filter form. Test plan : - Create an active budget "B_ACTIVE" with 1 fund - Create an inactive budget "B_OLD" with 3 funds - Go to "B_OLD" planning by libraries - You see 3 funds - In filter form, select "by months" in "Select planning type" => Without patch, you see planning of "B_ACTIVE" with 1 fund => Without patch, you see planning of "B_OLD" with 3 funds Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Created attachment 43309 [details] [review] [SIGNED-OFF]Bug 14653 - Acq planning export always use default active period In Acq planning /cgi-bin/koha/admin/aqplan.pl, left side filter and export forms have no parameter budget_period_id nor authcat, so the use the default active period. As said in code - IF PERIOD_ID IS DEFINED, GET THE PERIOD - ELSE GET THE ACTIVE PERIOD BY DEFAULT my $period = GetBudgetPeriod($budget_period_id); This patch corrects the export form. Test plan : - Create an active budget "B_ACTIVE" with 1 fund - Create an inactive budget "B_OLD" with 3 funds - Go to "B_OLD" planning by libraries - You see 3 funds - Click on "Submit" in export form => Without patch, you get the planning of "B_ACTIVE" with 1 fund => Without patch, you get the planning of "B_OLD" with 3 funds by libraries Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Created attachment 43378 [details] [review] Bug 14653 - Acq planning filter always use default active period In Acq planning /cgi-bin/koha/admin/aqplan.pl, left side filter and export forms have no parameter budget_period_id nor authcat, so the use the default active period. As said in code : - IF PERIOD_ID IS DEFINED, GET THE PERIOD - ELSE GET THE ACTIVE PERIOD BY DEFAULT my $period = GetBudgetPeriod($budget_period_id); This patch corrects the filter form. Test plan : - Create an active budget "B_ACTIVE" with 1 fund - Create an inactive budget "B_OLD" with 3 funds - Go to "B_OLD" planning by libraries - You see 3 funds - In filter form, select "by months" in "Select planning type" => Without patch, you see planning of "B_ACTIVE" with 1 fund => Without patch, you see planning of "B_OLD" with 3 funds Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 43379 [details] [review] Bug 14653 - Acq planning export always use default active period In Acq planning /cgi-bin/koha/admin/aqplan.pl, left side filter and export forms have no parameter budget_period_id nor authcat, so the use the default active period. As said in code - IF PERIOD_ID IS DEFINED, GET THE PERIOD - ELSE GET THE ACTIVE PERIOD BY DEFAULT my $period = GetBudgetPeriod($budget_period_id); This patch corrects the export form. Test plan : - Create an active budget "B_ACTIVE" with 1 fund - Create an inactive budget "B_OLD" with 3 funds - Go to "B_OLD" planning by libraries - You see 3 funds - Click on "Submit" in export form => Without patch, you get the planning of "B_ACTIVE" with 1 fund => Without patch, you get the planning of "B_OLD" with 3 funds by libraries Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> So it seems that only 1 library uses this feature :) Patches pushed to master. Thanks Frido! (In reply to Jonathan Druart from comment #8) > So it seems that only 1 library uses this feature :) Indeed :D Pushed to 3.20.x will be in 3.20.5 |