Summary: | Allow correct translation of CAS authentication | ||
---|---|---|---|
Product: | Koha | Reporter: | Fridolin Somers <fridolin.somers> |
Component: | I18N/L10N | Assignee: | Fridolin Somers <fridolin.somers> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | chris, dpavlin, f.demians, hector.hecaxmmx, sophie.meynieux, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5983 | ||
Change sponsored?: | --- | Patch complexity: | String patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 14671 - Allow correct translation of CAS authentication
[SIGNED-OFF]Bug 14671 - Allow correct translation of CAS authentication [PASSED QA] Bug 14671 - Allow correct translation of CAS authentication |
Description
Fridolin Somers
2015-08-11 08:16:57 UTC
Created attachment 41442 [details] [review] Bug 14671 - Allow correct translation of CAS authentication In authentication pages with CAS, the use of acronym or abbr tags does not allow a correct translation of the text. See http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5983#c7 It does not help a lot end users to know that CAS is Central Authentication Service, I think. Now one can custom the login page with NoLoginInstructions syspref to describe how to use the authentication. This patch removes the use of acronym and abbr is authentication pages. Test plan (example with fr-FR locale) : - Without patch - Update translation files : cd misc/translator ; perl translate update fr-FR - You see in fr-FR-opac-bootstrap.po : msgid "If you have a " - Is is translated in : msgstr "Si vous avez un compte " - Apply patch - Update translation files : cd misc/translator ; perl translate update fr-FR - You see in fr-FR-opac-bootstrap.po : msgid "If you have a CAS account, %s please " - You can now translate it : msgstr "Si vous avez un compte CAS, %s veuillez " - Same test for intranet authentication page - Install the translation : cd misc/translator ; perl translate install fr-FR - Look at the result Created attachment 43025 [details] [review] [SIGNED-OFF]Bug 14671 - Allow correct translation of CAS authentication In authentication pages with CAS, the use of acronym or abbr tags does not allow a correct translation of the text. See http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5983#c7 It does not help a lot end users to know that CAS is Central Authentication Service, I think. Now one can custom the login page with NoLoginInstructions syspref to describe how to use the authentication. This patch removes the use of acronym and abbr is authentication pages. Test plan (example with fr-FR locale) : - Without patch - Update translation files : cd misc/translator ; perl translate update fr-FR - You see in fr-FR-opac-bootstrap.po : msgid "If you have a " - Is is translated in : msgstr "Si vous avez un compte " - Apply patch - Update translation files : cd misc/translator ; perl translate update fr-FR - You see in fr-FR-opac-bootstrap.po : msgid "If you have a CAS account, %s please " - You can now translate it : msgstr "Si vous avez un compte CAS, %s veuillez " - Same test for intranet authentication page - Install the translation : cd misc/translator ; perl translate install fr-FR - Look at the result Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised. Tranlated OK, tested in spanish es-ES Hi Fridolin. Just one question, how the users will know the meaning of the acronym? Created attachment 43029 [details] [review] [PASSED QA] Bug 14671 - Allow correct translation of CAS authentication In authentication pages with CAS, the use of acronym or abbr tags does not allow a correct translation of the text. See http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5983#c7 It does not help a lot end users to know that CAS is Central Authentication Service, I think. Now one can custom the login page with NoLoginInstructions syspref to describe how to use the authentication. This patch removes the use of acronym and abbr is authentication pages. Test plan (example with fr-FR locale) : - Without patch - Update translation files : cd misc/translator ; perl translate update fr-FR - You see in fr-FR-opac-bootstrap.po : msgid "If you have a " - Is is translated in : msgstr "Si vous avez un compte " - Apply patch - Update translation files : cd misc/translator ; perl translate update fr-FR - You see in fr-FR-opac-bootstrap.po : msgid "If you have a CAS account, %s please " - You can now translate it : msgstr "Si vous avez un compte CAS, %s veuillez " - Same test for intranet authentication page - Install the translation : cd misc/translator ; perl translate install fr-FR - Look at the result Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised. Tranlated OK, tested in spanish es-ES Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> (In reply to Héctor Eduardo Castro Avalos from comment #3) > Hi Fridolin. > > Just one question, how the users will know the meaning of the acronym? I think today people are used to search on internet. And library can customise this login page to explain which authentication to choose. Patch pushed to master. Thanks Frido! Would it be possible to have it in 3.20 and 3.18 ? Thanks Pushed to 3.20.x will be in 3.20.6 |