| Summary: | Patron's transaction history changes items' order after paying fines | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Joonas Kylmälä <joonas.kylmala> |
| Component: | Patrons | Assignee: | Joonas Kylmälä <joonas.kylmala> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | minor | ||
| Priority: | P4 | CC: | f.demians, gmcharlt, jonathan.druart, kyle.m.hall, liz, tomascohen |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 14687: Patron's transaction history changes items' order after paying fines.
Bug 14687: Patron's transaction history changes items' order after paying fines. [PASSED QA] Bug 14687: Patron's transaction history changes items' order after paying fines. |
||
|
Description
Joonas Kylmälä
2015-08-17 12:29:07 UTC
Created attachment 41553 [details] [review] Bug 14687: Patron's transaction history changes items' order after paying fines. Sorts Patron's accounting data consistently from newest to oldest. It doesn't depend on anymore to timestamp (which can be same for multiple entries) from database but instead uses accountline's id to sort. Test plan for the patch above: 1. Go to: Staff side -> Patrons -> X patron -> Fines -> *Create manual invoice* 2. Create one invoice with amount of 1. 3. Create other invoice with amount of 2. 4. Go to tab *Account* and take a look how the transactions are ordered. 5. Go to tab *Pay fines* and click Pay amount and then confirm. 6. Now you can see that in the *Account* tab the order of transactions have changed and that they go in the wrong order now. 7. Apply patch and see that the transactions are now ordered from newest to oldest. Created attachment 44532 [details] [review] Bug 14687: Patron's transaction history changes items' order after paying fines. Sorts Patron's accounting data consistently from newest to oldest. It doesn't depend on anymore to timestamp (which can be same for multiple entries) from database but instead uses accountline's id to sort. Signed-off-by: Liz Rea <liz@catalyst.net.nz> Created attachment 44552 [details] [review] [PASSED QA] Bug 14687: Patron's transaction history changes items' order after paying fines. Sorts Patron's accounting data consistently from newest to oldest. It doesn't depend on anymore to timestamp (which can be same for multiple entries) from database but instead uses accountline's id to sort. Signed-off-by: Liz Rea <liz@catalyst.net.nz> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Patch pushed to master. Thanks Joonas! This patch has been pushed to 3.20.x, will be in 3.20.6. Pushed to 3.18.13, and released. |