Description
Julian FIOL
2015-08-21 14:41:50 UTC
Created attachment 41789 [details] [review] Bug 14707 : Replace UsageStatsCountry and UsageStatsLibraryType syspref from free text to a dropdown list. This will avoid syntax problems with Hea when a user will fill this 2 sysprefs The default choice for UsageStatsLibraryType and UsageStatsCountry is 'empty' Test Plan --------- 1. Create a new Koha install 2. Go to the 'Administration' page 3. Go to 'Global system preferences' 4. Go to 'Administration' 5. At the end of this page you should see a dropdown menu for - UsageStatsCountry with all countries - UsageStatsLibraryType with all type of library They both should be empty by default. Is it a good idea to have a country dropdown? Hi Tomás, We need to standardize users answers for 'country' and 'type' to avoid Hea issues. Why do you think a country dropdown would be a bad idea ? Do you have another solution in mind ? Thanks Hm, UsageStatsLibraryType already is a drop down, without this patch for me? I am also a bit worried about the country, because how complete of a list can we get and where? (In reply to Katrin Fischer from comment #4) > Hm, UsageStatsLibraryType already is a drop down, without this patch for me? Probably an error in the commit message, the patch only adds en empty choice for UsageStatsLibraryType > I am also a bit worried about the country, because how complete of a list > can we get and where? Even if we can't be sure we have the exhaustive list of countries, I think it is still better than having all possible forms of USA counted as different countries, not to mention spelling mistakes. I have to admit... I don't see a better solution :) Translating all those countries is a bit of a scary thought tho... There is no atomic update perl script which attempts to match the list to ensure it is in the drop down data set, because an upgrade won't necessarily be in the list. Isn't this a problem? Created attachment 44929 [details] [review] [SIGNED-OFF] Bug 14707 : Replace UsageStatsCountry and UsageStatsLibraryType syspref from free text to a dropdown list. This will avoid syntax problems with Hea when a user will fill this 2 sysprefs The default choice for UsageStatsLibraryType and UsageStatsCountry is 'empty' Test Plan --------- 1. Create a new Koha install 2. Go to the 'Administration' page 3. Go to 'Global system preferences' 4. Go to 'Administration' 5. At the end of this page you should see a dropdown menu for - UsageStatsCountry with all countries - UsageStatsLibraryType with all type of library They both should be empty by default. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Not a complete list but is a start Lots of new strings to translate :) No errors Hm, wondering: 1) The changes for the library type don't match up: societyAssoc: "society or association" vs societyAssociation 2) How can we handle installations that already have the preference set up, but the setting doesn't match one of the provided countries? 3) Please correct bug title and commit message - UsageStatsLibraryType already is a pull down on master. I am going to work on this one. Created attachment 55550 [details] [review] Bug 14707 : Replace UsageStatsCountry syspref from free text to a dropdown list. This will avoid syntax problems with Hea when a user will fill this 2 sysprefs The default choice for UsageStatsLibraryType and UsageStatsCountry is 'empty' Test Plan --------- 1. Create a new Koha install 2. Go to the 'Administration' page 3. Go to 'Global system preferences' 4. Go to 'Administration' 5. At the end of this page you should see a dropdown menu for - UsageStatsCountry with all countries - UsageStatsLibraryType with all type of library They both should be empty by default. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Not a complete list but is a start Lots of new strings to translate :) No errors Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 55551 [details] [review] Bug 14707: Update existing installations and correct wrong values See http://hea.koha-community.org/, the countries are filled is wrong values. If we decide to update the free text with a dropdown list, we need to handle these wrong data. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> We need this one to avoid other people to enter wrong data. Please QA, push and backport it ASAP. Created attachment 55552 [details] [review] Bug 14707: Update existing installations and correct wrong values See http://hea.koha-community.org/, the countries are filled is wrong values. If we decide to update the free text with a dropdown list, we need to handle these wrong data. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 55637 [details] [review] Bug 14707 : Replace UsageStatsCountry syspref from free text to a dropdown list. This will avoid syntax problems with Hea when a user will fill this 2 sysprefs The default choice for UsageStatsLibraryType and UsageStatsCountry is 'empty' Test Plan --------- 1. Create a new Koha install 2. Go to the 'Administration' page 3. Go to 'Global system preferences' 4. Go to 'Administration' 5. At the end of this page you should see a dropdown menu for - UsageStatsCountry with all countries - UsageStatsLibraryType with all type of library They both should be empty by default. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Not a complete list but is a start Lots of new strings to translate :) No errors Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 55638 [details] [review] Bug 14707: Update existing installations and correct wrong values See http://hea.koha-community.org/, the countries are filled is wrong values. If we decide to update the free text with a dropdown list, we need to handle these wrong data. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to master for 16.11, thanks Jonathan! Pushed in 16.05. Will be in 16.05.05. Pushed to 3.22.x, will be in 3.22.12 Question regarding translating: Should the translations keep the English names? (In reply to Marc Véron from comment #20) > Question regarding translating: > > Should the translations keep the English names? Trinidad & Tob. -- why not Tobago in full? CZ and GR were mapped to words. -- Why not "{description} ({code})"? In fact, why not everything just {code}? Why isn't the system preferences the code, and the pref file the one with the '{code}: "{description} ({code})"'? The description and code will make it easier to switch when dealing with a foreign UI language. There is nothing worse than changing your language in your electronics and not being able to figure out how to get back to the one you understand, because you can't read it. I think perhaps this should be a follow up bug? |