Summary: | The export tool is broken if used from the command line | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Command-line Utilities | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | major | ||
Priority: | P5 - low | CC: | chris, katrin.fischer, robin, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Bug Depends on: | 13040 | ||
Bug Blocks: | 14722 | ||
Attachments: |
Bug 14709: Do not access to C4::Context->userenv from the commandline
Patch fixes the bug. I don't see any side effects caused by the fix. [PASSED QA] Bug 14709: Do not access to C4::Context->userenv from the commandline |
Description
Jonathan Druart
2015-08-24 09:06:31 UTC
The severity could be increased to critical if someone occurs the issue. Created attachment 41818 [details] [review] Bug 14709: Do not access to C4::Context->userenv from the commandline The script dies with Can't use an undefined value as a HASH reference at tools/export.pl line 149. if it is called from the command line. This is introduced by bug 13040. The C4::Context->userenv is not defined in this case. Test plan: Execute the script using the command line. With the patch applies you should not get the error. Created attachment 41847 [details] [review] Patch fixes the bug. I don't see any side effects caused by the fix. Signed-off-by: Joonas Kylmälä <j.kylmala@gmail.com> Created attachment 42185 [details] [review] [PASSED QA] Bug 14709: Do not access to C4::Context->userenv from the commandline The script dies with Can't use an undefined value as a HASH reference at tools/export.pl line 149. if it is called from the command line. This is introduced by bug 13040. The C4::Context->userenv is not defined in this case. Test plan: Execute the script using the command line. With the patch applies you should not get the error. Signed-off-by: Joonas Kylmälä <j.kylmala@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Patch pushed to master. Thanks Jonathan! Pushed to 3.20.x will be in 3.20.4 |