Bug 14721

Summary: OAI-PMH must return error when no results
Product: Koha Reporter: Fridolin Somers <fridolin.somers>
Component: Web servicesAssignee: Fridolin Somers <fridolin.somers>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: minor    
Priority: P5 - low CC: chris, christophe.brocquet, liz, mirko, tomascohen
Version: Main   
Hardware: All   
OS: All   
See Also: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14664
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Bug 14721 - OAI-PMH must return error when no results
Bug 14721 - OAI-PMH must return error when no results
Bug 14721 - OAI-PMH must return error when no results

Description Fridolin Somers 2015-08-25 09:28:47 UTC
When getting records from OAI-PMH, an error must be returned if there is no results.

See : http://www.openarchives.org/OAI/openarchivesprotocol.html#ErrorConditions
Comment 1 Fridolin Somers 2015-08-25 09:50:12 UTC Comment hidden (obsolete)
Comment 2 Mirko Tietgen 2015-09-04 11:32:22 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2015-09-04 13:58:08 UTC
Created attachment 42404 [details] [review]
Bug 14721 - OAI-PMH must return error when no results

When getting records from OAI-PMH, an error must be returned if there is no results.

See : http://www.openarchives.org/OAI/openarchivesprotocol.html#ErrorConditions

Test plan :
- Enable OAI webservice
- Perform a query that will return no results. ie : /cgi-bin/koha/oai.pl?verb=ListRecords&metadataPrefix=marcxml&from=2099-12-30&until=2099-12-31
=> Without patch you get a response with :
   <ListRecords/>
=> With patch you get a response with error code :
   <error code="noRecordsMatch">No records match the given criteria</error>
- Check a good query returns still results
- Same test with ListIdentifiers verb

Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 4 Tomás Cohen Arazi 2015-09-07 14:31:49 UTC
Patch pushed to master.

Goood job Frido!
Comment 5 Chris Cormack 2015-09-22 02:00:16 UTC
Pushed to 3.20.x will be in 3.20.4
Comment 6 Liz Rea 2015-09-22 04:43:49 UTC
Pushed to 3.18.x will be in 3.18.11