| Summary: | Add API route to get top issues | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Julian Maurice <julian.maurice> |
| Component: | Web services | Assignee: | Julian Maurice <julian.maurice> |
| Status: | Failed QA --- | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | bgkriegel, josef.moravec, tomascohen |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Medium patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | 13799, 14788 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 14749: Add API route /v1/topissues
Bug 14749: Add API route /v1/topissues Bug 14749: Add API route /v1/topissues Bug 14749: Add unit tests for /topissues |
||
|
Description
Julian Maurice
2015-08-28 07:42:59 UTC
Created attachment 42047 [details] [review] Bug 14749: Add API route /v1/topissues See Swagger specification for documentation Refactor opac-topissues.pl code into C4::Circulation::GetTopIssues Patch complexity is 'Medium' because this change has many architectural connections Created attachment 42408 [details] [review] Bug 14749: Add API route /v1/topissues See Swagger specification for documentation Bug split to separate the refactoring of opac-topissues.pl (bug 14788) from the new API route Please, can you provide a test plan? Don't know what to do with this. Needs rebase, especially because of swagger specifiction being separate in more json files. Created attachment 71248 [details] [review] Bug 14749: Add API route /v1/topissues See Swagger specification for documentation Created attachment 71249 [details] [review] Bug 14749: Add unit tests for /topissues Patch rebased on master + tests Test plan: 1) Go to http://OPAC/cgi-bin/koha/opac-topissues.pl and http://OPAC/api/v1/topissues and compare the results. They must be the same, given a set of parameters Parameters matching: "Show the top" corresponds to api parameter 'count' "From" corresponds to api parameter 'branch' "Limit to" corresponds to api parameter 'itemtype' "Acquired in the last" corresponds to api parameter 'newness' (in days) Hi Julian, could you add your proposal to https://wiki.koha-community.org/wiki/REST_api_RFCs please? I think we'd like to change a few things like branch -> library, biblionumber -> biblio_id. Also adding Tomas to stop me if I am mistaken :) |