Bug 14772

Summary: Remove or clarify checkbox «flagged» on subfield visibility frameworks
Product: Koha Reporter: Pablo AB <pablo.bianchi>
Component: System AdministrationAssignee: Bugs List <koha-bugs>
Status: NEW --- QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: alexbuckley, caroline.cyr-la-rose, dcook, gmcharlt, m.de.rooy, marjorie.barry-vila, mtompset, severine.queune
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:

Description Pablo AB 2015-09-02 14:22:20 UTC
It seems no one know what is the utility of setting the subfield visibility to "flagged". Manual say nothing about: (2.4.1.4. Edit Framework Subfields > Advanced constraint values > Visibility) and related bug #9894 neither.

If this feature is only a historic vestiges should be removed, else the manual should say what it is.
Comment 1 Marcel de Rooy 2017-03-01 15:05:26 UTC
See also bug 15870/11592.
As far as I can tell, there is no difference between -8 (flagged) and 8 (all checkboxes are unchecked).
Comment 2 David Cook 2019-01-14 05:56:22 UTC
The only references I can find to "flagged" are in koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc_subfields_structure.tt and koha-tmpl/intranet-tmpl/prog/js/marc_subfields_structure.js.

And koha-tmpl/intranet-tmpl/prog/js/marc_subfields_structure.js is only found in koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc_subfields_structure.tt.

There is another reference to "-8" in Koha/Filter/MARC/ViewPolicy.pm.

--

It might be worth leaving in Koha/Filter/MARC/ViewPolicy.pm for backward compatibility for hiding values... but I think we could remove it from the templates.
Comment 3 Séverine Queune 2019-04-16 09:02:12 UTC
I tested the use of this option for items subfields and I'm not sure it should be suppressed, but adapted : this option is the only way (I found...) to hide subfields from the modification pages "Add item" and "Batch item modification".
It could be great to have the "Flagged" box checkable with the others (now, all others boxes are unchecked when used) so each library could define which subfields can be modified using the "Add item" page (checkbox "Editor") but hidden on the "Batch item modification" form.
But maybe my comment out of purpose...
Comment 4 Caroline Cyr La Rose 2023-05-01 18:51:34 UTC
(In reply to Séverine Queune from comment #3)
> I tested the use of this option for items subfields and I'm not sure it
> should be suppressed, but adapted : this option is the only way (I found...)
> to hide subfields from the modification pages "Add item" and "Batch item
> modification".
> It could be great to have the "Flagged" box checkable with the others (now,
> all others boxes are unchecked when used) so each library could define which
> subfields can be modified using the "Add item" page (checkbox "Editor") but
> hidden on the "Batch item modification" form.
> But maybe my comment out of purpose...

Unless I'm misunderstanding, I cannot reproduce this in the current master (22.12). If I uncheck 'Editor', the subfield is removed from both 'Add item' and 'Batch item modification'.

I agree that there is no way currently to make a subfield appear in the 'Add item' form, but not in the 'Batch item modification' form. You can use SubfieldsToAllowForRestrictedBatchmod if really this subfield shouldn't be allowed to be batch modified.

This probably should be the subject of another bug report, if there really is a need. I'm in favour of removing the 'flagged' option completely