| Summary: | can't search by username anymore | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Nicole C. Engard <nengard> |
| Component: | Patrons | Assignee: | Marc Véron <veron> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | major | ||
| Priority: | P5 - low | CC: | chris, dcook, gmcharlt, jdemuth, kyle.m.hall, liz, marjorie.barry-vila, tomascohen, veron |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 14782 - Add possibility to search patrons using the username (userid)
Bug 14782 - Add possibility to search patrons using the username (userid) Bug 14782: Add tests [PASSED QA] Bug 14782 - Add possibility to search patrons using the username (userid) |
||
|
Description
Nicole C. Engard
2015-09-03 17:15:42 UTC
Same on current master, I can not search after username (userid). Switching version from 1.18 to master (hope that is OK). Created attachment 42420 [details] [review] Bug 14782 - Add possibility to search patrons using the username (userid) This patch makes it possible to search for users using the username (userid / login name). To test: - Apply patch - Do searches from Home > Patrons - Search after a full username or parts of a username with Search fields = Standard and Search fields = Userid - Perform the searches from the top bar (expand with [+]) and from the "Filters" part at the left - Make sure that other searches behave as before Created attachment 42454 [details] [review] Bug 14782 - Add possibility to search patrons using the username (userid) This patch makes it possible to search for users using the username (userid / login name). To test: - Apply patch - Do searches from Home > Patrons - Search after a full username or parts of a username with Search fields = Standard and Search fields = Userid - Perform the searches from the top bar (expand with [+]) and from the "Filters" part at the left - Make sure that other searches behave as before Signed-off-by: Joonas Kylmälä <j.kylmala@gmail.com> I am in favor of this change, but it would be good to have a test to back it up! Created attachment 42498 [details] [review] Bug 14782: Add tests Run: perl t/db_dependent/Utils/Datatables_Members.t Created attachment 42499 [details] [review] [PASSED QA] Bug 14782 - Add possibility to search patrons using the username (userid) This patch makes it possible to search for users using the username (userid / login name). To test: - Apply patch - Do searches from Home > Patrons - Search after a full username or parts of a username with Search fields = Standard and Search fields = Userid - Perform the searches from the top bar (expand with [+]) and from the "Filters" part at the left - Make sure that other searches behave as before Signed-off-by: Joonas Kylmälä <j.kylmala@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Tried my hand at writing some... hopefully they are useful. Patches pushed to master. Thanks Katrina and Marc! Pushed to 3.20.x will be in 3.20.4 Pushed to 3.18.x will be in 3.18.11 |