Bug 14782

Summary: can't search by username anymore
Product: Koha Reporter: Nicole C. Engard <nengard>
Component: PatronsAssignee: Marc Véron <veron>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: major    
Priority: P5 - low CC: chris, dcook, gmcharlt, jdemuth, katrin.fischer, kyle.m.hall, liz, marjorie.barry-vila, tomascohen, veron
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Bug 14782 - Add possibility to search patrons using the username (userid)
Bug 14782 - Add possibility to search patrons using the username (userid)
Bug 14782: Add tests
[PASSED QA] Bug 14782 - Add possibility to search patrons using the username (userid)

Description Nicole C. Engard 2015-09-03 17:15:42 UTC
We used to be able to search by username when doing patron searching and that availability is gone.  I think this happened with the new patron search form in ajax.
Comment 1 Marc Véron 2015-09-05 14:41:42 UTC
Same on current master, I can not search after username (userid).

Switching version from 1.18 to master (hope that is OK).
Comment 2 Marc Véron 2015-09-05 14:58:34 UTC Comment hidden (obsolete)
Comment 3 Joonas Kylmälä 2015-09-08 11:41:06 UTC Comment hidden (obsolete)
Comment 4 Katrin Fischer 2015-09-13 15:49:37 UTC
I am in favor of this change, but it would be good to have a test to back it up!
Comment 5 Katrin Fischer 2015-09-13 16:12:43 UTC
Created attachment 42498 [details] [review]
Bug 14782: Add tests

Run:
perl t/db_dependent/Utils/Datatables_Members.t
Comment 6 Katrin Fischer 2015-09-13 16:13:20 UTC
Created attachment 42499 [details] [review]
[PASSED QA] Bug 14782 - Add possibility to search patrons using the username (userid)

This patch makes it possible to search for users using the username (userid / login name).

To test:

- Apply patch
- Do searches from Home > Patrons
- Search after a full username or parts of a username with Search fields = Standard and Search fields = Userid
- Perform the searches from the top bar (expand with [+]) and from the "Filters" part at the left
- Make sure that other searches behave as before

Signed-off-by: Joonas Kylmälä <j.kylmala@gmail.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 7 Katrin Fischer 2015-09-13 16:14:18 UTC
Tried my hand at writing some... hopefully they are useful.
Comment 8 Tomás Cohen Arazi 2015-09-16 13:53:19 UTC
Patches pushed to master.

Thanks Katrina and Marc!
Comment 9 Chris Cormack 2015-09-22 17:28:24 UTC
Pushed to 3.20.x will be in 3.20.4
Comment 10 Liz Rea 2015-09-22 23:25:08 UTC
Pushed to 3.18.x will be in 3.18.11