Bug 14812

Summary:	Help could not be displayed in the correct language
Product:	Koha	Reporter:	Jonathan Druart <jonathan.druart>
Component:	Templates	Assignee:	Jonathan Druart <jonathan.druart>
Status:	CLOSED FIXED	QA Contact:	Testopia <testopia>
Severity:	normal
Priority:	P5 - low	CC:	liz, tomascohen
Version:	Main
Hardware:	All
OS:	All
See Also:	http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14813
Change sponsored?:	---	Patch complexity:	Small patch
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:
Circulation function:
Attachments:	Bug 14812: Display the help in the correct language Bug 14812: Display the help in the correct language [PASSED QA] Bug 14812: Display the help in the correct language

Description Jonathan Druart 2015-09-14 09:32:42 UTC

If opaclanguages != language, the language of the help page is the default one (en).

To reproduce:
Set language to en, fr-FR, ar-Arab and opaclanguages to en, fr-FR

Translate the fr-FR and ar-Arab templates.
Go on the mainpage, switch to ar-Arab, go to the help page.
The page is displayed in English (fallback).

Comment 1 Jonathan Druart 2015-09-14 09:37:42 UTC Comment hidden (obsolete)

Created attachment 42509 [details] [review]
Bug 14812: Display the help in the correct language

If opaclanguages != language, the language of the help page is the
default one (en).

Test plan:
1/ Set language to en, fr-FR, ar-Arab and opaclanguages to en, fr-FR
2/ Translate the fr-FR and ar-Arab templates.
3/ Go on the mainpage, switch to ar-Arab, go to the help page.
The help page content should be in Arabian, not English.

Comment 2 Magnus Enger 2015-10-01 10:02:34 UTC Comment hidden (obsolete)

Created attachment 43001 [details] [review]
Bug 14812: Display the help in the correct language

If opaclanguages != language, the language of the help page is the
default one (en).

Test plan:
1/ Set language to en, fr-FR, ar-Arab and opaclanguages to en, fr-FR
2/ Translate the fr-FR and ar-Arab templates.
3/ Go on the mainpage, switch to ar-Arab, go to the help page.
The help page content should be in Arabian, not English.

Signed-off-by: Magnus Enger <magnus@libriotech.no>
Set language = en, sv-SE, nb-NO. opaclanguage = en, nb-NO
Went to the intranet main page, selected Swedish and clicked on help
Without the patch, help was displayed in English
With the patch, help was displayed in Swedish. Yay!

Comment 3 Katrin Fischer 2015-10-01 20:39:19 UTC

Created attachment 43031 [details] [review]
[PASSED QA] Bug 14812: Display the help in the correct language

If opaclanguages != language, the language of the help page is the
default one (en).

Test plan:
1/ Set language to en, fr-FR, ar-Arab and opaclanguages to en, fr-FR
2/ Translate the fr-FR and ar-Arab templates.
3/ Go on the mainpage, switch to ar-Arab, go to the help page.
The help page content should be in Arabian, not English.

Signed-off-by: Magnus Enger <magnus@libriotech.no>
Set language = en, sv-SE, nb-NO. opaclanguage = en, nb-NO
Went to the intranet main page, selected Swedish and clicked on help
Without the patch, help was displayed in English
With the patch, help was displayed in Swedish. Yay!

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Comment 4 Tomás Cohen Arazi (tcohen) 2015-10-02 18:27:02 UTC

Patch pushed to master.

Thanks Jonathan!

Comment 5 Liz Rea 2015-11-02 21:05:30 UTC

Pushed to 3.18.x, is in 3.18.12.