|
Description
Jonathan Druart
2015-09-14 14:02:40 UTC
Created attachment 42524 [details] [review] Bug 14817: Fix encoding issues in columns.def Test plan: 1/ Use a translated template (fr-FR or ar-Arab) 2/ Go on the tools/import_patrons.pl page 3/ The field names in the "default values" block should be correctly encoded. The patch works as expected for me, but there is another place to fix: https://github.com/Koha-Community/Koha/blob/master/C4/Reports/Guided.pm#L875 And there is used this routine from Reports::Guided https://github.com/Koha-Community/Koha/blob/master/tools/inventory.pl#L37 https://github.com/Koha-Community/Koha/blob/master/tools/inventory.pl#L374 Created attachment 42571 [details] [review] Bug 14817: (follow-up) Fix encoding issues in columns.def Follow-up for reports. Test plan: 1/ Use a translated template (fr-FR or ar-Arab) 2/ Go on the report guided page, step 3 3/ The field names should be correctly encoded. Thanks for the catch Josef, I haven't checked this area I thought it called the same subroutine. Created attachment 42582 [details] [review] Bug 14817: Fix encoding issues in columns.def Test plan: 1/ Use a translated template (fr-FR or ar-Arab) 2/ Go on the tools/import_patrons.pl page 3/ The field names in the "default values" block should be correctly encoded. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Created attachment 42583 [details] [review] Bug 14817: (follow-up) Fix encoding issues in columns.def Follow-up for reports. Test plan: 1/ Use a translated template (fr-FR or ar-Arab) 2/ Go on the report guided page, step 3 3/ The field names should be correctly encoded. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Created attachment 42713 [details] [review] [PASSED QA] Bug 14817: Fix encoding issues in columns.def Test plan: 1/ Use a translated template (fr-FR or ar-Arab) 2/ Go on the tools/import_patrons.pl page 3/ The field names in the "default values" block should be correctly encoded. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 42714 [details] [review] [PASSED QA] Bug 14817: (follow-up) Fix encoding issues in columns.def Follow-up for reports. Test plan: 1/ Use a translated template (fr-FR or ar-Arab) 2/ Go on the report guided page, step 3 3/ The field names should be correctly encoded. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Patches pushed to master. Thanks Jonathan! |