Summary: | SMSSendUsername and SMSSendPassword are not listed in the system preferences | ||
---|---|---|---|
Product: | Koha | Reporter: | Kyle M Hall <kyle.m.hall> |
Component: | Architecture, internals, and plumbing | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | major | ||
Priority: | P5 - low | CC: | chris, jonathan.druart, liz, tomascohen |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
See Also: |
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10784 http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13029 |
||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 14820: Add missing prefs SMSSendUsername and SMSSendPassword
Bug 14820: Add missing prefs SMSSendUsername and SMSSendPassword [PASSED QA] Bug 14820: Add missing prefs SMSSendUsername and SMSSendPassword |
Description
Kyle M Hall
2015-09-14 17:25:31 UTC
Hi Kyle, I found 2 related bugs: bug 10784 and 13029. Created attachment 42551 [details] [review] Bug 14820: Add missing prefs SMSSendUsername and SMSSendPassword These 2 system preferences are missing from the sysprefs.sql file. Test plan: Execute the updatedatabase script and confirm that the 2 prefs are now in the systempreferences table. Search for "sms" in the system preferences search box, you should see the 3 prefs. Created attachment 42708 [details] [review] Bug 14820: Add missing prefs SMSSendUsername and SMSSendPassword These 2 system preferences are missing from the sysprefs.sql file. Test plan: Execute the updatedatabase script and confirm that the 2 prefs are now in the systempreferences table. Search for "sms" in the system preferences search box, you should see the 3 prefs. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 42962 [details] [review] [PASSED QA] Bug 14820: Add missing prefs SMSSendUsername and SMSSendPassword These 2 system preferences are missing from the sysprefs.sql file. Test plan: Execute the updatedatabase script and confirm that the 2 prefs are now in the systempreferences table. Search for "sms" in the system preferences search box, you should see the 3 prefs. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Patch pushed to master. Thanks Jonathan! Pushed to 3.20.x will be in 3.20.5 Pushed to 3.18.x, is in 3.18.12. Liz, there is a problem when you have fixed the conflict on commit 6bc08252b4753b31cd73558bf492c03294a83592 Bug 14820: DBRev 3.18.11.001 You have taken the "DEVELOPER PROCESS" part, which is not in 3.18.x yet. So now 2 sql atomicupdate files are executed (oai_sets.sql and hourlyloans.sql). |