Summary: | misc/batchRebuildItemsTables.pl has hard coded record length limit of 99999 bytes. | ||
---|---|---|---|
Product: | Koha | Reporter: | Barton Chittenden <barton> |
Component: | Command-line Utilities | Assignee: | Barton Chittenden <barton> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | trivial | ||
Priority: | P5 - low | CC: | chris, jonathan.druart, nick, robin, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11399 | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 14858: removed record length limit test
Bug 14858: removed record length limit test Bug 14858: removed record length limit test |
Description
Barton Chittenden
2015-09-18 14:53:36 UTC
Created attachment 42744 [details] [review] Bug 14858: removed record length limit test Test plan: Import / Create a MARC record that is more than 99999 bytes (this can be done by creating many items; the 952 fields will bulk up the record). Manipulate the MARC on the large record so that some item fields (bulkmarcimport is a good candidate for creating and manipulating such a record). Run misc/batchRebuildItemsTables.pl, and note that item fields are not updated for the jumbo record. Apply the patch. Re-run misc/batchRebuildItemsTables.pl, and see that the item fields now match the jumbo record. Created attachment 42942 [details] [review] Bug 14858: removed record length limit test Signed-off-by: Nick Clemens <nick@quecheelibrary.org> Test plan was unclear, but here's what I did: 1 - Created a super big record (pasted a project gutenberg work into 520$b) 2 - Added items with $x - Non public and $z Public 3 - Mapped field x to items.itemnotes_nonpublic 4 - Checked mysql table, items.itemnotes_nonpublic was NULL 5 - Ran batchRebuildItemsTables.pl - received an error 6 - Checked mysql table, items.itemnotes_nonpublic was NULL 7 - Applied patch 8 - Ran batchRebuildItemsTables.pl - no error 9 - Checked mysql table, items.itemnotes_nonpublic was 'Non public' 10 - Signed off Created attachment 43013 [details] [review] Bug 14858: removed record length limit test Signed-off-by: Nick Clemens <nick@quecheelibrary.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Thanks for the test plan Nick! Patch pushed to master. Thanks Barton! Pushed to 3.20.x will be in 3.20.5 |