| Summary: | Remove C4::Dates from reserve/request.pl | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Marc Véron <veron> |
| Component: | Architecture, internals, and plumbing | Assignee: | Marc Véron <veron> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | jonathan.druart, josef.moravec, tomascohen |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | |||
| Bug Blocks: | 14870 | ||
| Attachments: |
Bug 14873 - Remove C4::Dates from reserve/request.pl
Bug 14873 - Remove C4::Dates from reserve/request.pl Bug 14873 - Remove C4::Dates from reserve/request.pl |
||
|
Description
Marc Véron
2015-09-22 14:34:36 UTC
Created attachment 42790 [details] [review] Bug 14873 - Remove C4::Dates from reserve/request.pl This bug removes deprecated C4::Dates from reserve/request.pl To test: - Apply patch - In staff client, search a biblio and try to put a hold for a borrower (Home > Catalog > [Some Biblio] > Place a hold to [Some biblio]) Created attachment 42806 [details] [review] Bug 14873 - Remove C4::Dates from reserve/request.pl This bug removes deprecated C4::Dates from reserve/request.pl To test: - Apply patch - In staff client, search a biblio and try to put a hold for a borrower (Home > Catalog > [Some Biblio] > Place a hold to [Some biblio]) Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Marc, Don't you think it is worth to use the KohaDates plugin in the templates and not manage at all the date formatting in the perl script? Jonathan, My aim is to get rid of C4::Dates as soon as possible, and touching as less files as possible, to finally be able to resolve Bug 12072 - New dateformat dd.mm.yyyy. 12072 is open since April 2014, blocked because C4::Dates is deprecated, really needed here - and hopefully resolved with the next release. There are a lot more places to be worked on (see Bug 14870), that's why I choose the fastest track (touch as less files as possible) - and because I'm running out of my (until now purely voluntary) time. Any help to move things forward (with or without KohaDates plugin) is really appreciated. Marc Created attachment 42835 [details] [review] Bug 14873 - Remove C4::Dates from reserve/request.pl This bug removes deprecated C4::Dates from reserve/request.pl To test: - Apply patch - In staff client, search a biblio and try to put a hold for a borrower (Home > Catalog > [Some Biblio] > Place a hold to [Some biblio]) Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Ok Marc, agreed! :) Patch pushed to master. Thanks Marc! |