Bug 14882

Summary: Librarians are not warned if patron owe more than maxoutstanding when placing holds
Product: Koha Reporter: Kyle M Hall <kyle.m.hall>
Component: Hold requestsAssignee: Kyle M Hall <kyle.m.hall>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: minor    
Priority: P5 - low CC: gmcharlt, gwilliams, jonathan.druart, tomascohen, veron
Version: unspecified   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on:    
Bug Blocks: 14883    
Attachments: Bug 14882 - Librarian's are not warned if patron owe more than maxoutstanding
Bug 14882 - Librarian's are not warned if patron owe more than maxoutstanding
Bug 14882 - Librarians are not warned if patron owe more than maxoutstanding when placing holds
[Signed-off] Bug 14882 - Librarians are not warned if patron owe more than maxoutstanding when placing holds
Bug 14882 - Librarians are not warned if patron owe more than maxoutstanding when placing holds

Description Kyle M Hall 2015-09-23 14:37:45 UTC
If a patron owes more than the system preference maxoutstanding in fees and fines, the patron will be unable to place holds via the opac. However, a librarian placing a hold for a patron is not even warned!
Comment 1 Kyle M Hall 2015-09-23 14:40:03 UTC Comment hidden (obsolete)
Comment 2 Kyle M Hall 2015-09-23 14:40:56 UTC Comment hidden (obsolete)
Comment 3 Kyle M Hall 2015-09-23 14:43:12 UTC Comment hidden (obsolete)
Comment 4 Marc Véron 2015-09-24 06:47:45 UTC Comment hidden (obsolete)
Comment 5 Jonathan Druart 2015-09-24 10:47:57 UTC
Created attachment 42838 [details] [review]
Bug 14882 - Librarians are not warned if patron owe more than maxoutstanding when placing holds

If a patron owes more than the system preference maxoutstanding in fees
and fines, the patron will be unable to place holds via the opac.
However, a librarian placing a hold for a patron is not even warned!

Test Plan:
1) Apply this patch
2) Set maxoutstanding to 1.00
3) Find a patron owing more than 1.00
4) Attempt to place a hold
5) Note the warning that the patron owes money

Works as expected.
Signed-off-by: Marc Véron <veron@veron.ch>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 6 Jonathan Druart 2015-09-24 10:49:10 UTC
I have tried to standardize the way this is calculated, OPAC vs intranet, but it's out of the scope of this bug...
Comment 7 Tomás Cohen Arazi 2015-09-25 18:44:00 UTC
Patch pushed to master.

Thanks Kyle!