Bug 14886

Summary:	Overdue notices: <<items.fine>> prints $0.00 when no fine exists.
Product:	Koha	Reporter:	Barton Chittenden <barton>
Component:	Notices	Assignee:	Bugs List <koha-bugs>
Status:	CLOSED WONTFIX	QA Contact:	Testopia <testopia>
Severity:	enhancement
Priority:	P5 - low
Version:	Main
Hardware:	All
OS:	All
See Also:	http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11144 http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14887
Change sponsored?:	---	Patch complexity:	---
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:
Circulation function:

Description Barton Chittenden 2015-09-24 12:28:23 UTC

The <<items.fine>> markup will print $0.00, even when no accountlines entry exists which corresponds to the current borrower/itemnumber.

To test:

Set up circ rules for two item types (A and B). Make the loan duration the same for both, but only charge fines on item type A.

Set up overdue notices which include <<items.fine>>.

Set up notice triggers.

Check out items of types A and B, back-dating the check-out so that both items trigger today.

Run fines.pl by hand. Check accountlines database, make sure that there is a fines entry for the item of  type A.

Run overdue_notices.pl by hand. Inspect the generated notice. Item of type B will show a fine of $0.00.

Comment 1 Katrin Fischer 2015-09-29 21:34:03 UTC

Hi Barton,

I am not sure this is a bug.  I'd prefer something like:

Title of book
Fine: 0,00€

to

Title of book
Fine: 

in the overdue notices. The first seems clearer to the user for me.

Comment 2 Barton Chittenden 2015-09-29 22:20:08 UTC

(In reply to Katrin Fischer from comment #1)
> Hi Barton,
> 
> I am not sure this is a bug.  I'd prefer something like:
> 
> Title of book
> Fine: 0,00€
> 
> to
> 
> Title of book
> Fine: 
> 
> in the overdue notices. The first seems clearer to the user for me.

Fair point, given that we don't have any conditional logic within the notices themselves (in which case, leaving off 'Fine:' would be my preference).

If I were receiving a notice, I think that I would prefer

Title of book
Fine: --

over

Title of book
Fine: 0,00€

but that's a quibble. I'll close the bug.