Summary: | Labels: allow empty lines in PDF export | ||
---|---|---|---|
Product: | Koha | Reporter: | Theodoros Theodoropoulos <theod> |
Component: | Label/patron card printing | Assignee: | Chris Nighswonger <cnighswonger> |
Status: | NEW --- | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | ||
Version: | 3.20 | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: |
Description
Theodoros Theodoropoulos
2015-09-25 07:42:29 UTC
FYI, there are two 'suspicious' line in the Label.pm code: 201: $f =~ s/^\s?//; 456: next LABEL_LINES if $line eq ''; that could be relevant to this issue, but even if they are commented out, the PDF output remains the same. Maybe additional changes should be made to the PDF creator. At present this is by design. I'd like to hear feedback from the koha user's list before removing it. We could also consider making it an option set in the layout. I find it difficult to understand why PDF creator should by default strip empty lines of text (I suppose there is a good reason for that), but even so, it is a bit confusing to the users because CSV and XML outputs follow a different approach and display empty lines and spaces. I don't know what the community thinks about this request, but my humble opinion would be not to overlook it and to -at least- have an option in the layout screen to not strip empty lines of text in PDF! An alternative idea (that does not involve changes to the layout screen) would be to strip empty lines -by default- when these are results of MARC fields -as you do now-, but display them when they are simple text (in single quotes)... (In reply to Theodoros Theodoropoulos from comment #3) > An alternative idea (that does not involve changes to the layout screen) > would be to strip empty lines -by default- when these are results of MARC > fields -as you do now-, but display them when they are simple text (in > single quotes)... As I recall the problem was that imported MARC records tend to have various fields which include spaces/non-print chars but no data for whatever reason (probably due to sloppy data entry or messed up MARC editors, etc.). It was not readily obvious that empty fields contained spaces, etc., so the easiest approach was to strip all blank fields when creating labels. This is the first time I recall it being a problem, however, I think that adding a switch for this to the layout screen is a very good approach to resolving it. It should be fairly straightforward to do this. Personally, I cannot commit to doing it any time soon, but perhaps someone else might be able to. |