|
Description
Winona Salesky
2015-09-28 15:25:17 UTC
Status is Needs Sign-off but there is no patch :-) Sorry, having some trouble with git bz. Just tried again and received another 200 error. -Winona (In reply to Marc Véron from comment #1) > Status is Needs Sign-off but there is no patch :-) Created attachment 42968 [details] [review] Patch correcting icon path Created attachment 43022 [details] [review] [SIGNED-OFF]Bug 14917 - RDA: 700/710/711 fix path for icon in XSLT. Added theme and materialTypeLabel parameters back into showAuthor template call for 7xx display in OPAC display. Test Plan: 1) Apply this patch 2) Ensure you are using the default XSLT setting for the staff and opac record details 3) Find or create a record with MARC tags 700,710,711 5) Click title to review record details. 6) Link to icon following contributor names should appear. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as expected. Magnifying glass icon corrected Created attachment 43023 [details] [review] [SIGNED-OFF]Bug 14917 - RDA: 700/710/711 fix path for icon in XSLT. Added theme and materialTypeLabel parameters back into showAuthor template call for 7xx display in OPAC display. Test Plan: 1) Apply this patch 2) Ensure you are using the default XSLT setting for the staff and opac record details 3) Find or create a record with MARC tags 700,710,711 5) Click title to review record details. 6) Link to icon following contributor names should appear. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as expected. Magnifying glass icon corrected Created attachment 43097 [details] [review] [PASSED QA] Bug 14917 - RDA: 700/710/711 fix path for icon in XSLT. Added theme and materialTypeLabel parameters back into showAuthor template call for 7xx display in OPAC display. Test Plan: 1) Apply this patch 2) Ensure you are using the default XSLT setting for the staff and opac record details 3) Find or create a record with MARC tags 700,710,711 5) Click title to review record details. 6) Link to icon following contributor names should appear. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as expected. Magnifying glass icon corrected Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Patch pushed to master. Thanks Winona! Great! Thank you. -Winona (In reply to Tomás Cohen Arazi from comment #7) > Patch pushed to master. > > Thanks Winona! Hi, Winona, Yes, the marc I copied in my original comment was straight from the record. I copy/pasted. Dani |