|
Description
Marc Véron
2015-09-29 14:09:05 UTC
Created attachment 42952 [details] [review] Bug 14923 - Remove C4::Dates from labels/label-item-search.pl This patch removes C4::Dates from labels/label-item-search.pl To test: - Go to Home > Tools > Labels home > Manage label batches - Click "Add item(s)" - Verify that selection with date after and date before works the same as without patch. Created attachment 42960 [details] [review] [SIGNED-OFF]Bug 14923 - Remove C4::Dates from labels/label-item-search.pl This patch removes C4::Dates from labels/label-item-search.pl To test: - Go to Home > Tools > Labels home > Manage label batches - Click "Add item(s)" - Verify that selection with date after and date before works the same as without patch. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised. C4::Dates is deprecated according to Coding Guidelines Wiki. Marc, sorry but I get a software error if the date is not correctly formatted. Created attachment 43030 [details] [review] Bug 14923 - (follow-up) Test for invalid date input See comment #3 To test: - Make sure that you test on top of Bug 14936 (Add validation for date strings to Koha::DateUtils - Apply patch - Go to Home > Tools > Labels home > Manage label batches - Click "Add item(s)" - Verify that selection with date after and date before works the same as without patch. - Verify that you can not trigger a software error using invalid dates as 0000-00-00 or 32/01/1970 (copy/paste to date fields). Comment on attachment 43030 [details] [review] Bug 14923 - (follow-up) Test for invalid date input Obsoleted to implement solution without using is_formatted_date_string Created attachment 43064 [details] [review] Bug 14923 - (follow up) Add test for invalid dates using eval To test: - Apply patch - Go to Home > Tools > Labels home > Manage label batches - Click "Add item(s)" - Verify that selection with date after and date before works the same as without patch. - Verify that you can not trigger a software error using invalid dates as 0000-00-00 or 32/01/1970 (copy/paste to date fields). I re-do the patch from scratch. Created attachment 43139 [details] [review] Bug 14923 - Remove C4::Dates from labels/label-item-search.pl This patch removes C4::Dates from labels/label-item-search.pl To test: - Go to Home > Tools > Labels home > Manage label batches - Click "Add item(s)" - Verify that selection with date after and date before works the same as without patch. Created attachment 43145 [details] [review] [SIGNED-OFF]Bug 14923 - Remove C4::Dates from labels/label-item-search.pl This patch removes C4::Dates from labels/label-item-search.pl To test: - Go to Home > Tools > Labels home > Manage label batches - Click "Add item(s)" - Verify that selection with date after and date before works the same as without patch. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised. Tested with bad dates Created attachment 43154 [details] [review] Bug 14923 - Remove C4::Dates from labels/label-item-search.pl This patch removes C4::Dates from labels/label-item-search.pl To test: - Go to Home > Tools > Labels home > Manage label batches - Click "Add item(s)" - Verify that selection with date after and date before works the same as without patch. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised. Tested with bad dates Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Todo later: Some checks should be added on client side. Patch pushed to master. Thanks Marc! |