|
Description
Marc Véron
2015-09-29 16:41:40 UTC
Created attachment 42956 [details] [review] Bug 14926 - Remove C4::Dates from members/printfeercpt.pl This patch removes C4::Dates from members/printfeercpt.pl To test: - Go to a patron's fines (members/boraccount.pl) and make sure that he/she has made a payment - Select 'Print' in the payment's line - Verify that the payment date on the slip displays correctly Created attachment 43143 [details] [review] Bug 14946 - Remove C4::Dates from files acqui/*.pl This patch removes C4::Dates from: - acqui/histsearch.pl - acqui/invoice.pl - acqui/invoices.pl - acqui/orderreceive.pl - acqui/parcel.pl - acqui/parcels.pl - acqui/transferorder.pl To test: - Apply patch - Go to Home > Acquisitions > Invoices - Verify that Search filters work OK - Edit an invoice - Verify that Shipment date and Billing date display OK and edit / save is OK - Receive shipment for a vendor - Verify that Shipment date behaves OK and that you can filter list of shipents for this vendor - Transfer an item from a basket to another vendor Comment on attachment 43143 [details] [review] Bug 14946 - Remove C4::Dates from files acqui/*.pl Mistaked with bug number, sorry for the noise. Created attachment 43262 [details] [review] [SIGNED-OFF]Bug 14926 - Remove C4::Dates from members/printfeercpt.pl This patch removes C4::Dates from members/printfeercpt.pl To test: - Go to a patron's fines (members/boraccount.pl) and make sure that he/she has made a payment - Select 'Print' in the payment's line - Verify that the payment date on the slip displays correctly Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised. Date displayed 2015-10-08 (In reply to Héctor Eduardo Castro Avalos from comment #4) > Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> > Works as advertised. Date displayed 2015-10-08 Yes but YYYY-MM-DD is the iso format. If you change your pref to something else, it will be the iso format too. So the patch does not work. Created attachment 43290 [details] [review] Bug 14926: Format the date according to the dateformat syspref Please try again with the last patch, and don't forget to change your dateformat pref to something else than iso :) (In reply to Jonathan Druart from comment #7) > Please try again with the last patch, and don't forget to change your > dateformat pref to something else than iso :) Okidoki Created attachment 43301 [details] [review] [SIGNED-OFF]Bug 14926: Format the date according to the dateformat syspref Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised. Tested with the three values from dateformat syspref Created attachment 43418 [details] [review] Bug 14926 - Remove C4::Dates from members/printfeercpt.pl This patch removes C4::Dates from members/printfeercpt.pl To test: - Go to a patron's fines (members/boraccount.pl) and make sure that he/she has made a payment - Select 'Print' in the payment's line - Verify that the payment date on the slip displays correctly Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised. Date displayed 2015-10-08 Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 43419 [details] [review] Bug 14926: Format the date according to the dateformat syspref Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised. Tested with the three values from dateformat syspref Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Patches pushed to master. Thanks Marc! |